-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] suggest using eas build:dev when using simulator/emulator dev client configuration #2929
base: main
Are you sure you want to change the base?
Conversation
…ev client configuration
This stack of pull requests is managed by Graphite. Learn more about stacking. |
❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. |
Subscribed to pull request
Generated by CodeMention |
Size Change: +1.69 kB (0%) Total Size: 53.4 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2929 +/- ##
==========================================
- Coverage 52.68% 52.63% -0.04%
==========================================
Files 588 588
Lines 23219 23240 +21
Branches 4614 4623 +9
==========================================
Hits 12231 12231
- Misses 10954 10975 +21
Partials 34 34 ☔ View full report in Codecov by Sentry. |
Log.log( | ||
`🔎 You are using a build configuration that could benefit from using ${chalk.bold( | ||
'eas build:dev' | ||
)} command. Run it to install and run cached dev client build or create a new one if it doesn't exist.` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
)} command. Run it to install and run cached dev client build or create a new one if it doesn't exist.` | |
)} command. Run it to install and run cached development build, or create a new one if a compatible build doesn't exist yet.` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's give it a try!
private maybeSuggestUsingEasBuildDev(buildProfiles?: ProfileData<'build'>[]): void { | ||
// suggest using eas build:dev if the build configuration results in simulator/emulator dev client build | ||
if ( | ||
buildProfiles?.some(({ profile, platform }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's also not show this message on CI
it might also be useful to check for a build with the same profile with a matching fingerprint and let people know about that |
Why
Suggest using
eas build:dev
if one runseas build
resulting in simulator/emulator dev client build.How
Add log to suggest using
eas build:dev
Test Plan
Tests