Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] suggest using eas build:dev when using simulator/emulator dev client configuration #2929

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Mar 5, 2025

Why

Suggest using eas build:dev if one runs eas build resulting in simulator/emulator dev client build.

How

Add log to suggest using eas build:dev

Test Plan

Tests

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Mar 5, 2025

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

@szdziedzic szdziedzic marked this pull request as ready for review March 5, 2025 11:49
Copy link

github-actions bot commented Mar 5, 2025

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Mar 5, 2025

Size Change: +1.69 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +1.69 kB (0%)

compressed-size-action

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.

Project coverage is 52.63%. Comparing base (34c307c) to head (06f961d).

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/build/index.ts 4.35% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2929      +/-   ##
==========================================
- Coverage   52.68%   52.63%   -0.04%     
==========================================
  Files         588      588              
  Lines       23219    23240      +21     
  Branches     4614     4623       +9     
==========================================
  Hits        12231    12231              
- Misses      10954    10975      +21     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Log.log(
`🔎 You are using a build configuration that could benefit from using ${chalk.bold(
'eas build:dev'
)} command. Run it to install and run cached dev client build or create a new one if it doesn't exist.`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
)} command. Run it to install and run cached dev client build or create a new one if it doesn't exist.`
)} command. Run it to install and run cached development build, or create a new one if a compatible build doesn't exist yet.`

Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's give it a try!

private maybeSuggestUsingEasBuildDev(buildProfiles?: ProfileData<'build'>[]): void {
// suggest using eas build:dev if the build configuration results in simulator/emulator dev client build
if (
buildProfiles?.some(({ profile, platform }) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also not show this message on CI

@brentvatne
Copy link
Member

it might also be useful to check for a build with the same profile with a matching fingerprint and let people know about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants