Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Design Pass based on User Feedback #114

Merged
merged 28 commits into from
Mar 10, 2023
Merged

refactor: Design Pass based on User Feedback #114

merged 28 commits into from
Mar 10, 2023

Conversation

amym114
Copy link
Collaborator

@amym114 amym114 commented Mar 10, 2023 •
edited
Loading

This PR addresses the following issues:
#104, #105, #106, #111

TODO in next PR

  • Add buttons for game details to About page, as well as tightening up styles on that page
  • Adjust card_media component to clip rather than squish images

About page

Screenshot 2023-03-10 at 14-26-44 Game Box

Arena Lobby w/ new messaging

Host
Screenshot 2023-03-10 at 2 11 46 PM
Player
Screenshot 2023-03-10 at 2 11 51 PM

Game Details:

Host
Screenshot 2023-03-10 at 2 12 48 PM
Player
Screenshot 2023-03-10 at 2 12 53 PM

@amym114 amym114 marked this pull request as ready for review March 10, 2023 21:27
nschello
nschello reviewed Mar 10, 2023
View reviewed changes
lib/game_box_web/live/about_live.ex Outdated Show resolved Hide resolved
lib/game_box_web/live/start_live.ex Outdated Show resolved Hide resolved
lib/game_box_web/templates/layout/live.html.heex Outdated Show resolved Hide resolved
@amym114 amym114 requested a review from nschello March 10, 2023 22:34
@amym114 amym114 merged commit a29f7af into main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschello nschello nschello left review comments

@bhelx bhelx bhelx approved these changes

@grossvogel grossvogel Awaiting requested review from grossvogel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amym114 @bhelx @nschello