Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked Bar: Fixing how stacked values are handled #530

Closed
wants to merge 3 commits into from

Conversation

rokotyan
Copy link
Contributor

@rokotyan rokotyan commented Feb 5, 2025

Fixes Stacked Bar rendering when the dataset has both positive and negative values returned by a single accessor function #521.

Before

image

After

image

@lee00678
Copy link
Collaborator

@rokotyan is this differ or has update from #525?

@rokotyan
Copy link
Contributor Author

@lee00678 They seem to be the same. Most likely I got busy and forgot that I've already create a PR. But what confuses me is why this PR shows the same Files changed if the previous one was already merged with the same changes?

@lee00678
Copy link
Collaborator

@lee00678 They seem to be the same. Most likely I got busy and forgot that I've already create a PR. But what confuses me is why this PR shows the same Files changed if the previous one was already merged with the same changes?

My guess is because this branch hasn't rebased from main.

@rokotyan
Copy link
Contributor Author

@lee00678 GitHub should use the current main to compare changes. Anyway, let's just close this PR.

@rokotyan rokotyan closed this Feb 10, 2025
@lee00678
Copy link
Collaborator

@lee00678 GitHub should use the current main to compare changes. Anyway, let's just close this PR.

Yes it should. But I think since you didn't rebase, this happens: https://github.com/orgs/community/discussions/39031?utm_source=chatgpt.com#discussioncomment-6992389

@rokotyan
Copy link
Contributor Author

@lee00678 Interesting, thanks for sharing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants