List attributes in database page #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leonkenneth
commented
Feb 5, 2025
•
leonkenneth
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Résultats des tests E2E Playwright
Details
Skipped testsfirefox › map-page.spec.ts › Carte › doit contenir les éléments nécessaires |
leonkenneth
changed the title
leonkenneth
force-pushed
the
list-attributes-in-database-page
branch
from
0085e0c to
70a09eb
Compare
Be resilient to API issues for homepage and tools page Remove databases YAML and logos, as they are in the backend now Proper search and highlighting are in another PR
leonkenneth
force-pushed
the
list-attributes-in-database-page
branch
from
1d4f256 to
67c49b2
Compare
|
Qu'est-ce que ça donne sur téléphone ? |
Pas génial effectivement. Je vais faire une repasse de responsive |
bbaret
reviewed
Feb 11, 2025
Comment on lines
+81
to
+94
| const relevantAttributesPerDatabase: { [key: number]: Attribute[] } = {}; | ||
|
|
||
| const databasesMatchingQuery = databases.filter((database) => { | ||
| if (search.length == 0) return true; | ||
|
|
||
| relevantAttributesPerDatabase[database.id] = database.attributes.filter( | ||
| (attribute) => | ||
| attribute.description.toLowerCase().includes(search.toLowerCase()), | ||
| ); | ||
| return relevantAttributesPerDatabase[database.id].length > 0; | ||
| }); | ||
|
|
||
| const displayedDatabases = | ||
| databasesMatchingQuery.length > 0 ? databasesMatchingQuery : databases; |
There was a problem hiding this comment.
Pas obligatoire ici mais en bonne pratique pour les perfs: quand tu as des variables calculées, tu peux utiliser un useMemo pour éviter de recalculer le tout lors du rerender qui peut arriver assez fréquemment.
bbaret
approved these changes
Feb 11, 2025
|
J'ai màj le CSS du responsive. J'ai mis des screenshots supplémentaires de ce que ça donne dans la PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.