Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TryFrom<u64> and TryFrom<u128> bounds to the FieldElement trait #244

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Add TryFrom<u64> and TryFrom<u128> bounds to the FieldElement trait #244

merged 1 commit into from
Feb 6, 2024

Conversation

Fumuran
Copy link
Contributor

@Fumuran Fumuran commented Feb 6, 2024

This small PR implements the TryFrom<u64> and TryFrom<u128> bounds for the structs which implements FieldElement trait, namely:

  • BaseElement(u64)
  • BaseElement(u128)
  • QuadExtension
  • CubeExtension

@Fumuran Fumuran force-pushed the andrew-fix-fieldelement branch from 86f2e26 to 450da89 Compare February 6, 2024 19:25
irakliyk
irakliyk reviewed Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a few small comments/questions inline.

@Fumuran Fumuran force-pushed the andrew-fix-fieldelement branch from 450da89 to 1c16448 Compare February 6, 2024 21:01
@Fumuran Fumuran requested a review from irakliyk February 6, 2024 21:02
@Fumuran Fumuran force-pushed the andrew-fix-fieldelement branch from 1c16448 to 2c51ed5 Compare February 6, 2024 21:11
irakliyk
irakliyk approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@irakliyk irakliyk merged commit c342515 into facebook:main Feb 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irakliyk irakliyk irakliyk approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fumuran @irakliyk @facebook-github-bot