felt u64: add conversion to/from usize #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also: - Reorders conversion definitions so that integer types are in increasing order - Changes the conversions to use `.into()` instead of `as` casts, when the conversion is infallible. Instead of the cast like `as u128` which at first sight doesn't guarantee no truncation
hackaugusto
force-pushed
the
hacka-usize-conversion
branch
from
321595b to
87a5810
Compare
irakliyk
approved these changes
May 9, 2024
irakliyk
pushed a commit
that referenced
this pull request
May 9, 2024
This commit also: - Reorders conversion definitions so that integer types are in increasing order - Changes the conversions to use `.into()` instead of `as` casts, when the conversion is infallible. Instead of the cast like `as u128` which at first sight doesn't guarantee no truncation
irakliyk
pushed a commit
that referenced
this pull request
May 9, 2024
This commit also: - Reorders conversion definitions so that integer types are in increasing order - Changes the conversions to use `.into()` instead of `as` casts, when the conversion is infallible. Instead of the cast like `as u128` which at first sight doesn't guarantee no truncation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also:
increasing order
.into()instead ofascasts, whenthe conversion is infallible. Instead of the cast like
as u128whichat first sight doesn't guarantee no truncation