Skip to content

Commit

Permalink
fix broken test
Browse files Browse the repository at this point in the history
  • Loading branch information
anupambhatnagar committed Feb 9, 2023
1 parent 23db900 commit d3a3c78
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions hta/common/trace.py
Original file line number Diff line number Diff line change
Expand Up @@ -637,10 +637,10 @@ def convert_time_series_to_events(
Returns a list of json events that can be appended to the trace.
"""
required_columns = ["tid", "pid", "ts", counter_col]
required_columns = ["pid", "ts", counter_col]
if not set(required_columns).issubset(series.columns):
logger.warning(
"Time seried dataframe does NOT contain required columns "
"Time series dataframe does NOT contain required columns "
f"{required_columns}, columns contained = {series.columns}"
)
return []
Expand Down
2 changes: 1 addition & 1 deletion tests/test_trace_analysis.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def test_generate_trace_with_counters(self, mock_write_trace):

counter_events = [ev for ev in trace_json["traceEvents"] if ev["ph"] == PHASE_COUNTER]
print(f"Trace has {len(counter_events)} counter events")
self.assertGreaterEqual(len(counter_events), 23000)
self.assertGreaterEqual(len(counter_events), 21000)

counter_names = {ev["name"] for ev in counter_events}
self.assertEqual(
Expand Down

0 comments on commit d3a3c78

Please sign in to comment.