Remove model protocol #633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69216298 |
|
This pull request was exported from Phabricator. Differential Revision: D69216298 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Feb 6, 2025
Summary: Pull Request resolved: facebookresearch#633 The extra model protocol is no longer necessary with a consistent base apsych model class. Differential Revision: D69216298
JasonKChow
force-pushed
the
export-D69216298
branch
from
cacf4a5 to
30b6475
Compare
Summary: Pull Request resolved: facebookresearch#446 monotonic projection gp is a subclass of GPClassificationGP so just need to make sure the methods specific to it can handle device change. Differential Revision: D65625994
Summary: Semi P models mostly already worked with GPU but didn't have a test. Copied a test over and fixed a missing device move. Differential Revision: D69209985
Summary: Everything should use the same model mixin now. This means that all models should work on GPU now as well. Differential Revision: D69194015
Summary: Pull Request resolved: facebookresearch#633 The extra model protocol is no longer necessary with a consistent base apsych model class. Differential Revision: D69216298
|
This pull request was exported from Phabricator. Differential Revision: D69216298 |
JasonKChow
force-pushed
the
export-D69216298
branch
from
30b6475 to
ca65524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The extra model protocol is no longer necessary with a consistent base apsych model class.
Differential Revision: D69216298