fix process group init logic and add pg_desc parsing #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaekyungHeo
requested review from
kingchc,
louisfeng,
sunghlin,
shengbao-zheng and
briancoutinho
as code owners
facebook-github-bot
added
the
CLA Signed
|
@shengfukevin Could you please help review? Thanks |
|
@shengfukevin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
TaekyungHeo
force-pushed
the
sanshang/fix_pg_init
branch
from
0ef5713 to
7d72c8e
Compare
|
@TaekyungHeo has updated the pull request. You must reimport the pull request before landing. |
1. parse pg description. 2. clear unused functions and members.
TaekyungHeo
force-pushed
the
sanshang/fix_pg_init
branch
from
7d72c8e to
666af99
Compare
|
@TaekyungHeo has updated the pull request. You must reimport the pull request before landing. |
shengfukevin
pushed a commit
to shengfukevin/param
that referenced
this pull request
Dec 11, 2024
…h#186) Summary: This DIFF include the following changes: parse pg description. fix pg creation logic. Pull Request resolved: facebookresearch#186 Test Plan: buck2 run -c fbcode.nvcc_arch='h100a' mode/opt -c hpc_comms.use_ncclx=2.21.5 param_bench/train/comms/pt:launcher -- --launcher mast --dp networkai_mast_job_identity --cluster MastProdCluster --hw grandteton --nnode 8 --ppn 8 --module commsTraceReplay_v2 --trace-path manifold://pytorch_execution_trace/tree/traces/shengfu/nv/pattern2-64gpu --trace-type et --json_mast_flex_pool_id_override_map ~/flex_pool_long_cable.json --reuse-tensors --warmup-iter 5 --num-replays 10 Differential Revision: D67071961 Pulled By: shengfukevin
|
@shengfukevin merged this pull request in ca00ca3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
comm_replay --trace-type et --trace-path /home/sanshang/lustre_storage/000_code/chakra/traces_wait_fix_1/et --num-replays 10