Update SPDL Image Classification Example with Dataloader #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66724034 |
vbourgin
pushed a commit
to vbourgin/spdl
that referenced
this pull request
Dec 3, 2024
…earch#289) Summary: Update SPDL image classification example to use Dataloader instead of Pipeline. The dataloader builds a Pipeline when converted to an iterable. Minor difference: the default concurrency is used in the Dataloader aggregator Differential Revision: D66724034
vbourgin
force-pushed
the
export-D66724034
branch
from
41b8561 to
e4e8d1f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66724034 |
mthrok
reviewed
Dec 13, 2024
| @@ -43,7 +43,7 @@ | |||
| import spdl.io | |||
| import spdl.utils | |||
| import torch | |||
| from spdl.pipeline import Pipeline, PipelineBuilder | |||
| from spdl.dataloader._dataloader import DataLoader | |||
There was a problem hiding this comment.
Suggested change
| from spdl.dataloader._dataloader import DataLoader | |
| from spdl.dataloader import DataLoader |
mthrok
approved these changes
Dec 13, 2024
vbourgin
pushed a commit
to vbourgin/spdl
that referenced
this pull request
Dec 13, 2024
…earch#289) Summary: Update SPDL image classification example to use Dataloader instead of Pipeline. The dataloader builds a Pipeline when converted to an iterable. Minor difference: the default concurrency is used in the Dataloader aggregator Reviewed By: moto-meta Differential Revision: D66724034
vbourgin
force-pushed
the
export-D66724034
branch
from
e4e8d1f to
c969e98
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66724034 |
vbourgin
pushed a commit
to vbourgin/spdl
that referenced
this pull request
Dec 14, 2024
…earch#289) Summary: Update SPDL image classification example to use Dataloader instead of Pipeline. The dataloader builds a Pipeline when converted to an iterable. Minor difference: the default concurrency is used in the Dataloader aggregator Reviewed By: moto-meta Differential Revision: D66724034
vbourgin
force-pushed
the
export-D66724034
branch
from
c969e98 to
e03b51a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66724034 |
vbourgin
pushed a commit
to vbourgin/spdl
that referenced
this pull request
Dec 14, 2024
…earch#289) Summary: Update SPDL image classification example to use Dataloader instead of Pipeline. The dataloader builds a Pipeline when converted to an iterable. Minor difference: the default concurrency is used in the Dataloader aggregator Reviewed By: moto-meta Differential Revision: D66724034
vbourgin
force-pushed
the
export-D66724034
branch
from
e03b51a to
56d0c47
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66724034 |
vbourgin
pushed a commit
to vbourgin/spdl
that referenced
this pull request
Dec 23, 2024
…earch#289) Summary: Update SPDL image classification example to use Dataloader instead of Pipeline. The dataloader builds a Pipeline when converted to an iterable. Minor difference: the default concurrency is used in the Dataloader aggregator Reviewed By: moto-meta Differential Revision: D66724034
vbourgin
force-pushed
the
export-D66724034
branch
from
56d0c47 to
69677b1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66724034 |
…earch#289) Summary: Update SPDL image classification example to use Dataloader instead of Pipeline. The dataloader builds a Pipeline when converted to an iterable. Minor difference: the default concurrency is used in the Dataloader aggregator Reviewed By: moto-meta Differential Revision: D66724034
vbourgin
force-pushed
the
export-D66724034
branch
from
69677b1 to
540a91e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66724034 |
facebook-github-bot
merged commit 1eda64b
into
facebookresearch:main
5 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Update SPDL image classification example to use Dataloader instead of Pipeline.
The dataloader builds a Pipeline when converted to an iterable.
Minor difference: the default concurrency is used in the Dataloader aggregator
Differential Revision: D66724034