Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix generating TypeScript type definitions #236

Merged
merged 2 commits into from
Dec 31, 2023
Merged

fix generating TypeScript type definitions #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1434b21
fix generating TypeScript type definitions
endel Dec 31, 2023
fa41b42
revert 'types' script at root level
endel Dec 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/publish-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ jobs:
env:
BUILDARCH: ${{ matrix.arch }}
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: npm run prebuild
run: npm run prebuild

# code is not ready... if anyone needs it, I am open for PR
# prebuild-cross:
Expand Down Expand Up @@ -201,7 +201,7 @@ jobs:

- name: Build types
if: needs.version-check.outputs.changed == 'true'
run: npm run types
run: npm run types

- run: npm publish --tag stable --workspace main --workspace transports/http3-quiche
if: ${{ needs.version-check.outputs.changed == 'true' && github.ref == 'refs/heads/master' }}
Expand Down
9 changes: 2 additions & 7 deletions main/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
{
"compilerOptions": {
"outDir": "dist",
"rootDir": "../",
"outDir": "dist"
},
"extends": "../tsconfig.base.json",
"include": [
"lib",
"test",
"../transports/http3-quiche/lib"
],
"include": [ "lib" ],
"exclude": [
"test/testinone.js"
]
Expand Down
6 changes: 2 additions & 4 deletions transports/http3-quiche/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
{
"compilerOptions": {
"outDir": "dist",
"rootDir": "../.."
"outDir": "dist"
},
"extends" : "../../tsconfig.base.json",
"include": [
"lib",
"../../main/lib"
"lib"
],
"references": [{ "path": "../../main" }]
}