-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: test that quicheLogVerbose is a number #263
Conversation
According to the types `quicheLogVerbose` when passed as an option should be a number, the test here asserts it's a function, so it's not possible to enable verbose quiche logging. Signed-off-by: Alex Potsides <alex@achingbrain.net>
@martenrichter any idea what the number should be to get quiche to output something? |
If I remember correctly, an integer 1,2,3 for the different levels. |
The valid values [are](fails-components#263 (comment)) 1 | 2 | 3 so only accept those as values.
Hmm, I still don't see anything in the terminal - I can see the output of |
It may be stderr, you have to look at the absl logging impl. |
I don't think stderr would be hidden, I'm running things using the node cli in zsh, stdout and stderr appear as expected but nothing from quiche. |
Then I do not know, it may be broken. So, I may have used it before the reorganization. I can look into it..., but it does not seem that I redirected the log output... Most times I use print for diagnosis for the stuff that I need. |
The valid values [are](fails-components#263 (comment)) 1 | 2 | 3 so only accept those as values.
The valid values [are](#263 (comment)) 1 | 2 | 3 so only accept those as values.
According to the types
quicheLogVerbose
when passed as an option should be a number, the test here asserts it's a function, so it's not possible to enable verbose quiche logging.