Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test that quicheLogVerbose is a number #263

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

achingbrain
Copy link
Contributor

@achingbrain achingbrain commented Mar 5, 2024

According to the types quicheLogVerbose when passed as an option should be a number, the test here asserts it's a function, so it's not possible to enable verbose quiche logging.

According to the types `quicheLogVerbose` when passed as an option should be a number, the test here asserts it's a function, so it's not possible to enable verbose quiche logging.

Signed-off-by: Alex Potsides <alex@achingbrain.net>
@martenrichter martenrichter enabled auto-merge (rebase) March 5, 2024 17:59
@achingbrain
Copy link
Contributor Author

@martenrichter any idea what the number should be to get quiche to output something?

@martenrichter
Copy link
Member

If I remember correctly, an integer 1,2,3 for the different levels.
But I think it is coming through stderr, stdout. I can not remember if I programmed a redirect to the javascript console, I wanted.

achingbrain added a commit to achingbrain/webtransport that referenced this pull request Mar 5, 2024
The valid values [are](fails-components#263 (comment))
1 | 2 | 3 so only accept those as values.
@achingbrain
Copy link
Contributor Author

Hmm, I still don't see anything in the terminal - I can see the output of printf lines I put in the c++ code, so I would have thought I'd see some quiche log output if this option does what it's supposed to do.

@martenrichter
Copy link
Member

It may be stderr, you have to look at the absl logging impl.

@martenrichter martenrichter merged commit 8826f8a into fails-components:master Mar 5, 2024
4 checks passed
@achingbrain
Copy link
Contributor Author

I don't think stderr would be hidden, I'm running things using the node cli in zsh, stdout and stderr appear as expected but nothing from quiche.

@achingbrain achingbrain deleted the patch-4 branch March 5, 2024 18:39
@martenrichter
Copy link
Member

Then I do not know, it may be broken. So, I may have used it before the reorganization. I can look into it..., but it does not seem that I redirected the log output... Most times I use print for diagnosis for the stuff that I need.

martenrichter pushed a commit to achingbrain/webtransport that referenced this pull request Mar 8, 2024
The valid values [are](fails-components#263 (comment))
1 | 2 | 3 so only accept those as values.
martenrichter pushed a commit that referenced this pull request Mar 8, 2024
The valid values [are](#263 (comment))
1 | 2 | 3 so only accept those as values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants