Skip to content

Commit

Permalink
Fix CodeSmell
Browse files Browse the repository at this point in the history
  • Loading branch information
fakoua committed Mar 1, 2024
1 parent 02d2d8a commit 7073fab
Show file tree
Hide file tree
Showing 15 changed files with 27 additions and 26 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Logs
/.scannerwork
logs
*.log
npm-debug.log*
Expand Down
6 changes: 6 additions & 0 deletions deno.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions q-manui/src/components/dashboard/CriticalComponent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@
</style>

<script lang="ts">
import { defineComponent } from 'vue';
import { PropType } from 'vue';
import { defineComponent, PropType } from 'vue';
import { ServiceModel } from '../models';
Expand Down
2 changes: 1 addition & 1 deletion q-manui/src/components/dashboard/DashboardComponent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ export default defineComponent({
lst = _take(_sortBy(lst, [1]).reverse(), 5);
lst.forEach((dep) => {
dep[0] = services.find((s) => s.name === dep[0])?.displayName || dep[0];
dep[0] = services.find((s) => s.name === dep[0])?.displayName ?? dep[0];
});
model.value.topDeps = lst;
};
Expand Down
3 changes: 1 addition & 2 deletions q-manui/src/components/dashboard/LogonComponent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@
</style>

<script lang="ts">
import { defineComponent } from 'vue';
import { PropType } from 'vue';
import { defineComponent, PropType } from 'vue';
export default defineComponent({
name: 'LogonComponent',
Expand Down
3 changes: 1 addition & 2 deletions q-manui/src/components/dashboard/ServiceTypeComponent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,7 @@
</style>

<script lang="ts">
import { defineComponent } from 'vue';
import { PropType } from 'vue';
import { defineComponent, PropType } from 'vue';
export default defineComponent({
name: 'ServiceTypeComponent',
Expand Down
3 changes: 1 addition & 2 deletions q-manui/src/components/dashboard/SummaryComponent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@
</template>

<script lang="ts">
import { defineComponent } from 'vue';
import { PropType } from 'vue';
import { defineComponent, PropType } from 'vue';
import { ServiceStatusModel } from '../models';
Expand Down
3 changes: 1 addition & 2 deletions q-manui/src/components/dashboard/SystemInfoComponent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,7 @@
</template>

<script lang="ts">
import { defineComponent } from 'vue';
import { PropType } from 'vue';
import { defineComponent, PropType } from 'vue';
import { SystemModel } from '../models';
Expand Down
3 changes: 1 addition & 2 deletions q-manui/src/components/dashboard/TopDependencyComponent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@
</style>

<script lang="ts">
import { defineComponent } from 'vue';
import { PropType } from 'vue';
import { defineComponent, PropType } from 'vue';
export default defineComponent({
name: 'TopDependencyComponent',
Expand Down
1 change: 0 additions & 1 deletion q-manui/src/components/processes/ProcessesComponent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ export default defineComponent({
onMounted(async () => {
isLoading.value = true;
const response = await serviceApi.getProcesses(props.host);
//data.value = response;
data.value = _.chain(response)
.groupBy('processName')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ export default defineComponent({
);
return dependsOn.map((v) => {
const svr = (services as ServiceModel[]).find(
const svr = (services).find(
(s: ServiceModel) => s.name == v.antecedent,
);
return {
Expand All @@ -209,7 +209,7 @@ export default defineComponent({
);
return antecedentsOn.map((v) => {
const svr = (services as ServiceModel[]).find(
const svr = (services).find(
(s: ServiceModel) => s.name == v.dependent,
);
return {
Expand All @@ -230,37 +230,37 @@ export default defineComponent({
if (!props.service) {
return true;
}
return props.service!.state !== 'Stopped';
return props.service.state !== 'Stopped';
});
const disableStop = computed(() => {
if (!props.service) {
return true;
}
return !props.service!.acceptStop;
return !props.service.acceptStop;
});
const disablePause = computed(() => {
if (!props.service) {
return true;
}
return !(
props.service!.state === 'Running' && props.service!.acceptPause
props.service.state === 'Running' && props.service.acceptPause
);
});
const disableResume = computed(() => {
if (!props.service) {
return true;
}
return props.service!.state !== 'Paused';
return props.service.state !== 'Paused';
});
const disableRestart = computed(() => {
if (!props.service) {
return true;
}
return props.service!.state !== 'Running';
return props.service.state !== 'Running';
});
onMounted(async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export default defineComponent({
);
return dependsOn.map((v) => {
const svr = (services as ServiceModel[]).find(
const svr = (services).find(
(s: ServiceModel) => s.name == v.antecedent,
);
return {
Expand Down Expand Up @@ -159,7 +159,7 @@ export default defineComponent({
);
return antecedentsOn.map((v) => {
const svr = (services as ServiceModel[]).find(
const svr = (services).find(
(s: ServiceModel) => s.name == v.dependent,
);
return {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ export default defineComponent({
const service = this.selected[0] as ServiceModel;
this.setDisabledControls(service);
this.$emit('onSelectService', row as ServiceModel);
this.$emit('onSelectService', row);
},
columnStyle(col: QTableColumn) {
return col.name === 'caption' ? 'min-width: 310px' : '';
Expand Down
3 changes: 2 additions & 1 deletion q-manui/src/router/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ import routes from './routes';
* with the Router instance.
*/

export default route(function (/* { store, ssrContext } */) {
export default route(function () {
//NOSONAR
const createHistory = process.env.SERVER
? createMemoryHistory
: process.env.VUE_ROUTER_MODE === 'history'
Expand Down
2 changes: 1 addition & 1 deletion q-manui/src/stores/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ declare module 'pinia' {
* with the Store instance.
*/

export default store((/* { ssrContext } */) => {
export default store(() => {
const pinia = createPinia();
pinia.use(piniaPluginPersistedstate);

Expand Down

0 comments on commit 7073fab

Please sign in to comment.