frontend bug fix #450
reviewdog ["detekt"] report
reported by reviewdog 🐶
Findings (1)
app/src/main/java/ru/practicum/android/diploma/search/presentation/SearchJobFragment.kt|38 col 1| Needless blank line(s)
Filtered Findings (27)
app/src/main/java/ru/practicum/android/diploma/filter/presentation/FilterSettingsFragment.kt|129 col 17| The function render is too long (44). The maximum length is 40.
app/src/main/java/ru/practicum/android/diploma/filter/presentation/FilterSettingsFragment.kt|129 col 17| The function render appears to be too complex based on Cognitive Complexity (complexity: 15). Defined complexity threshold for methods is set to '15'
app/src/main/java/ru/practicum/android/diploma/filter/presentation/FilterIndustryFragment.kt|70 col 17| The function render is too long (42). The maximum length is 40.
app/src/main/java/ru/practicum/android/diploma/filter/presentation/FilterIndustryFragment.kt|70 col 17| The function render appears to be too complex based on Cyclomatic Complexity (complexity: 10). Defined complexity threshold for methods is set to '10'
app/src/main/java/ru/practicum/android/diploma/filter/presentation/FilterRegionFragment.kt|77 col 17| The function renderStateLiveData appears to be too complex based on Cyclomatic Complexity (complexity: 10). Defined complexity threshold for methods is set to '10'
app/src/main/java/ru/practicum/android/diploma/utils/Mok.kt|14 col 8| Class Mok is too large. Consider splitting it into smaller pieces.
app/src/main/java/ru/practicum/android/diploma/search/presentation/SearchJobFragment.kt|44 col 18| The function onViewCreated is too long (48). The maximum length is 40.
app/src/main/java/ru/practicum/android/diploma/search/presentation/SearchJobFragment.kt|98 col 17| The function renderSearchState is too long (98). The maximum length is 40.
app/src/main/java/ru/practicum/android/diploma/search/presentation/SearchJobFragment.kt|31 col 7| Class SearchJobFragment is too large. Consider splitting it into smaller pieces.
app/src/main/java/ru/practicum/android/diploma/search/presentation/SearchJobFragment.kt|98 col 17| The function renderSearchState appears to be too complex based on Cyclomatic Complexity (complexity: 10). Defined complexity threshold for methods is set to '10'
app/src/main/java/ru/practicum/android/diploma/network/data/dto/responses/VacancyByIdResponse.kt|12 col 26| The constructor(description: String, employer: Employer?, id: String, name: String, salary: Salary?, contacts: Contacts?, areaDTO: AreaDTO, experience: Experience?, employment: Employment?, keySkills: List, vacancyUrl: String) has too many parameters. The current threshold is set to 7.
app/src/main/java/ru/practicum/android/diploma/network/data/repository/RetrofitBasedClient.kt|23 col 26| The function doRequest is too long (76). The maximum length is 40.
app/src/main/java/ru/practicum/android/diploma/network/data/repository/RetrofitBasedClient.kt|23 col 26| The function doRequest appears to be too complex based on Cyclomatic Complexity (complexity: 17). Defined complexity threshold for methods is set to '10'
app/src/main/java/ru/practicum/android/diploma/network/data/repository/RetrofitBasedClient.kt|23 col 26| The function doRequest appears to be too complex based on Cognitive Complexity (complexity: 17). Defined complexity threshold for methods is set to '15'
app/src/main/java/ru/practicum/android/diploma/di/DataModule.kt|3 col 1| Imports must be ordered according to the pattern specified in .editorconfig
app/src/main/java/ru/practicum/android/diploma/di/InteractorModule.kt|3 col 1| Imports must be ordered according to the pattern specified in .editorconfig
app/src/main/java/ru/practicum/android/diploma/di/RepositoryModule.kt|3 col 1| Imports must be ordered according to the pattern specified in .editorconfig
app/src/main/java/ru/practicum/android/diploma/favorites/domain/impl/FavoriteDbInteractorImpl.kt|3 col 1| Imports must be ordered according to the pattern specified in .editorconfig
app/src/main/java/ru/practicum/android/diploma/db/data/repository/VacancyRepositoryImpl.kt|3 col 1| Imports must be ordered according to the pattern specified in .editorconfig
app/src/main/java/ru/practicum/android/diploma/db/data/db/entity/EmployerEntity.kt|14 col 1| Needless blank line(s)
app/src/main/java/ru/practicum/android/diploma/search/domain/model/SearchParameters.kt|13 col 1| Needless blank line(s)
app/src/main/java/ru/practicum/android/diploma/search/domain/model/LogoUrlsModel.kt|9 col 1| Needless blank line(s)
app/src/main/java/ru/practicum/android/diploma/search/presentation/viewmodel/SearchViewModel.kt|185 col 1| Needless blank line(s)
app/src/main/java/ru/practicum/android/diploma/search/ui/VacancyAdapter.kt|50 col 1| Needless blank line(s)
app/src/main/java/ru/practicum/android/diploma/details/domain/impl/DetailsDbInteractorImpl.kt|3 col 1| Imports must be ordered according to the pattern specified in .editorconfig
app/src/main/java/ru/practicum/android/diploma/details/presentation/viewmodel/VacancyDetailsViewModel.kt|27 col 1| Needless blank line(s)
app/src/main/java/ru/practicum/android/diploma/filter/domain/impl/PlaceToWorkFilterInteractorImpl.kt|35 col 26| Function getCountryForRegion has 3 return statements which exceeds the limit of 2.
Annotations
github-actions / "detekt"
["detekt"] app/src/main/java/ru/practicum/android/diploma/search/presentation/SearchJobFragment.kt#L38 <detekt.NoConsecutiveBlankLines>
Needless blank line(s)
Raw output
/home/runner/work/diploma-team_4-koh_11-practicum-android/diploma-team_4-koh_11-practicum-android/app/src/main/java/ru/practicum/android/diploma/search/presentation/SearchJobFragment.kt:38:1: warning: Needless blank line(s) (detekt.NoConsecutiveBlankLines)