fix(pkg): properly spawn bash shell in builder containers as login shells #321
Conversation
poiana
added
kind/bug
|
For now, this just highlights the bug by adding a new regression test config specifically for centos 3.x that uses the |
|
Most probably, when run by driverkit, the |
| @@ -259,6 +259,7 @@ func (bp *DockerBuildProcessor) Start(b *builder.Build) error { | |||
| Env: envs, | |||
| Cmd: []string{ | |||
| "/bin/bash", | |||
| "-l", | |||
There was a problem hiding this comment.
By setting the "login" flag to bash, we enforce it to load data from bashrc/bash profiles.
See https://stackoverflow.com/questions/55206227/why-bashrc-is-not-executed-when-run-docker-container.
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
… script. This will enforce bash to parse bashrc / bash profile files. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
FedeDP
force-pushed
the
fix/centos_3.x_builder_image
branch
from
61ae9f3 to
cfc5dbf
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EXONER4TED, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FedeDP
changed the title
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
/area tests
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: