feat(decl): rename declarative commands namespace to suite
#283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
|
LGTM label has been added. Git tree hash: 03597e7ec0860aa47864eff57dfc1e2953238355
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, ekoops The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
leogr
reviewed
Feb 26, 2025
| @@ -13,6 +13,6 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| // Package config provides the implementation of Config, the configuration shared among declarative commands. Among | |||
| // other shared settings, it also stores the values of the shared flags. | |||
| // Package config provides the implementation of Config, the configuration shared among suite commands. Among other | |||
There was a problem hiding this comment.
Suggested change
| // Package config provides the implementation of Config, the configuration shared among suite commands. Among other | |
| // Package config provides the implementation of Config, the configuration shared among suite-related commands. Among other |
Comment on lines
+31
to
+32
| Short: "Manage everything related to test suites", | ||
| Long: "Manage everything related to test suites", |
There was a problem hiding this comment.
Suggested change
| Short: "Manage everything related to test suites", | |
| Long: "Manage everything related to test suites", | |
| Short: "Manage test suites described via YAML files", | |
| Long: "Provide sub-commands to work with test suites described via YAML files", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area commands
What this PR does / why we need it:
This PR renames the
declarativecommands namespace to the more suitablesuite.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: