Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suite/step/syscalls): add exactly-one-arg constraint support #285

Closed

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Mar 7, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:

This PR introduces exactly-one-arg constraint, allowing to specify that exactly one argument, among a list of specified arguments, must be directly set or bound (through field bindings) by the user. This requires all the involved fields to have also a default value.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana
Copy link

poiana commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ekoops
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the size/L label Mar 7, 2025
Introduce exactly-one-arg constraint allowing to specify that
exactly one argument, among a list of specified arguments, must be
directly set or bound (through field bindings) by the user. This
requires all the involved fields to have also a default value.

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops ekoops force-pushed the ekoops/add-exactly-one-arg-constr branch from 058a51e to 88e39ed Compare March 7, 2025 14:02
@ekoops
Copy link
Contributor Author

ekoops commented Mar 7, 2025

/hold

@ekoops ekoops closed this Mar 7, 2025
@ekoops ekoops deleted the ekoops/add-exactly-one-arg-constr branch March 7, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants