update(plugins/cloudtrail): support pre-ControlTower organization trails #650
Conversation
Rules files suggestionsrulesComparing No changes detected |
There was a problem hiding this comment.
Hi, thanks for the contribution!
the change itself looks good to me. I'd just update the comment to avoid potential issues understanding what that use case is about in the future. Here's the reference in AWS docs: https://docs.aws.amazon.com/controltower/latest/userguide/logging-using-cloudtrail.html
|
@legobrick: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Some pre-ControlTower organization Cloutrail trails are missing the OrgId in the AWSLogs S3 path. Making the OrgId optional gives them the option to use S3AccountList. Signed-off-by: Uli Heilmeier <uh@heilmeier.eu>
uhei
force-pushed
the
cloudtail-pre-controltower
branch
from
97ae651 to
b32a0e3
Compare
|
LGTM label has been added. Git tree hash: 561e28bb9cb9b31db75cf8dd732bc871aa36771d
|
|
@legobrick: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: legobrick, leogr, uhei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Rules files suggestionsrulesComparing No changes detected |
What type of PR is this?
/kind cleanup
/kind feature
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
Some pre-ControlTower organization Cloutrail trails are missing the OrgId in the AWSLogs S3 path. Making the OrgId optional gives them the option to use S3AccountList.