Refactor GetVersion() into a property

falox · Nov 23, 2020 · 69406e8 · 69406e8
1 parent dcb1fb4
commit 69406e8
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 10 deletions.
diff --git a/src/libvirt/Connect.cs b/src/libvirt/Connect.cs
@@ -25,7 +25,7 @@ public void Open(bool readOnly = false)
         {
             if (IsDisposed)
             {
-                throw new ObjectDisposedException(null, "Cannot open a disposed Connect.");
+                throw new ObjectDisposedException("Connect", "Cannot open a disposed connection.");
             }
 
             if (readOnly)

diff --git a/src/libvirt/Libvirt.cs b/src/libvirt/Libvirt.cs
@@ -34,16 +34,18 @@ private static IntPtr ImportResolver(string libraryName, Assembly assembly, DllI
 
         public const int VIR_UUID_BUFLEN = 36;
 
-        public static Version GetVersion()
+        public static Version Version
         {
-            LibvirtHelper.ThrowExceptionOnError(virGetVersion(out ulong libVer, null, out _));
-
-            int release = (int) (libVer % 1000);
-            int minor = (int) ((libVer % 1000000) / 1000);
-            int major = (int) (libVer / 1000000);
+            get
+            {
+                LibvirtHelper.ThrowExceptionOnError(virGetVersion(out ulong libVer, null, out _));
 
-            return new Version(major, minor, release);
+                int release = (int) (libVer % 1000);
+                int minor = (int) ((libVer % 1000000) / 1000);
+                int major = (int) (libVer / 1000000);
 
+                return new Version(major, minor, release);
+            }
         }
 
         #region Library

diff --git a/src/libvirt/libvirt.csproj b/src/libvirt/libvirt.csproj
@@ -3,7 +3,7 @@
   <PropertyGroup>
     <TargetFramework>netcoreapp3.1</TargetFramework>
     <AssemblyName>libvirt-csharp</AssemblyName>
-    <Version>0.0.1-alpha1</Version>
+    <Version>0.0.1-alpha2</Version>
     <SignAssembly>true</SignAssembly>
     <AssemblyOriginatorKeyFile>libvirt-csharp.snk</AssemblyOriginatorKeyFile>
   </PropertyGroup>

diff --git a/tests/libvirt.Tests/LibraryTests.cs b/tests/libvirt.Tests/LibraryTests.cs
@@ -7,7 +7,11 @@ public class LibraryTests
         [Fact]
         public void GetVersion_ReturnVersion()
         {
-            Libvirt.GetVersion();
+            // Act
+            var version = Libvirt.Version;
+
+            // Assert
+            Assert.True(version > new System.Version(0,0,1));
         }
     }
 }