Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock req versions + release number #261

Merged
merged 13 commits into from
Jan 27, 2025
Merged

Lock req versions + release number #261

merged 13 commits into from
Jan 27, 2025

Conversation

MScatolin
Copy link
Contributor

No description provided.

@MScatolin MScatolin requested a review from ianBtesser December 11, 2024 23:09
Copy link
Contributor

@mihelich mihelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MScatolin I thought were pinning protobuf to 5.27.x?

@mihelich
Copy link
Contributor

The CI failures appear to be caused by actions/runner-images#10636. Our CI workflows using ubuntu-latest have been upgraded to the new ubuntu-24.04 image, which contains a stricter GCC. Let's just pin those to ubuntu-20.04 instead of ubuntu-latest, matching some of our other workflows including the PyPI release.

Copy link
Contributor

@mihelich mihelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MScatolin note clean-up comments, otherwise LGTM. Thanks!

@MScatolin MScatolin merged commit a3be45b into main Jan 27, 2025
15 checks passed
@MScatolin MScatolin deleted the lock_req_versions branch January 27, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants