Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

35 support query parameters in api url #36

Merged
merged 14 commits into from
Oct 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EntityImporterDefinition.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ interface EntityImporterDefinition
*/
public function getName(): string;

/***
/**
* Description displayed in "Available import types" overview.
*
* @return string
Expand Down
17 changes: 12 additions & 5 deletions src/Reader/ApiReader.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
use Fastbolt\EntityImporter\EntityImporterDefinition;
use Fastbolt\EntityImporter\Reader\Api\PagePaginationStrategy;
use Fastbolt\EntityImporter\Reader\Api\PaginationStrategy;
use Fastbolt\EntityImporter\Types\ImportSourceDefinition\Api;
use Fastbolt\EntityImporter\Types\ImportSourceDefinition\ImportSourceDefinition;
use GuzzleHttp\Client;
use GuzzleHttp\Exception\RequestException;
Expand All @@ -29,7 +30,7 @@ class ApiReader implements ReaderInterface

private EntityImporterDefinition $importerDefinition;

private ImportSourceDefinition $importSourceDefinition;
private ImportSourceDefinition|Api $importSourceDefinition;

private array $options;

Expand All @@ -54,9 +55,12 @@ public function __construct(
) {
$this->clientFactory = $clientFactory;
$this->importerDefinition = $importerDefinition;
$this->importSourceDefinition = $importerDefinition->getImportSourceDefinition();
$this->options = $options;

/** @var Api $apiTmp */
$apiTmp = $importerDefinition->getImportSourceDefinition();
$this->importSourceDefinition = $apiTmp;

Assert::keyExists($this->options, 'api_key');

if (!isset($this->options['pagination_strategy'])) {
Expand Down Expand Up @@ -120,23 +124,26 @@ public function valid(): bool
*/
private function loadBulkData(int $offset): void
{
/** @var Api $importSourceDefinition */
$importSourceDefinition = $this->importSourceDefinition;
$clientFactory = $this->clientFactory;
$client = $clientFactory();

/** @var PaginationStrategy $paginationStrategy */
$paginationStrategy = $this->options['pagination_strategy'];
$paginationParameters = $paginationStrategy->getRequestParameters($offset);
$queryParameters = $importSourceDefinition->getQueryParameters();
$requestParameters = array_merge_recursive(
[
'verify' => false,
'headers' => [
'Accept' => 'application/json',
'X-AUTH-TOKEN' => $this->importSourceDefinition->getOptions()['api_key'],
'X-AUTH-TOKEN' => (string) $importSourceDefinition->getOptions()['api_key'],
],
],
$paginationParameters
array_merge_recursive($queryParameters, $paginationParameters)
);
$url = $this->importSourceDefinition->getSource();
$url = $importSourceDefinition->getSource();
$requestMethod = Request::METHOD_GET;

try {
Expand Down
23 changes: 19 additions & 4 deletions src/Types/ImportSourceDefinition/Api.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,25 @@ class Api implements ImportSourceDefinition
*/
private array $options;

/*
* @var array<array-key, mixed>
*/
private array $queryParameters;

private bool $throwOnSourceUnavailable = true;

/**
* @param string $apiHost
* @param string $apiPath
* @param array<string,mixed> $options
* @param string $apiHost
* @param string $apiPath
* @param array<string,mixed> $options
* @param array<string,string> $queryParameters
*/
public function __construct(string $apiHost, string $apiPath, array $options)
public function __construct(string $apiHost, string $apiPath, array $options, array $queryParameters = [])
{
$this->options = $options;
$this->apiHost = $apiHost;
$this->apiPath = $apiPath;
$this->queryParameters = $queryParameters;
}

/**
Expand Down Expand Up @@ -72,6 +79,14 @@ public function getOptions(): array
return $this->options;
}

/**
* @return array<array-key, mixed>
*/
public function getQueryParameters(): array
{
return $this->queryParameters;
}

/**
* @return ArchivingStrategy
*/
Expand Down
Loading