DOC: FauCard: note possible bug in Exception handling

fau-fablab · Nov 18, 2023 · 3a39705 · 3a39705
1 parent d5826a7
commit 3a39705
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/FabLabKasse/faucardPayment/FAUcardPaymentThread.py b/FabLabKasse/faucardPayment/FAUcardPaymentThread.py
@@ -350,6 +350,7 @@ def check_last_transaction(cur, con):
             pos = magpos.MagPOS(cfg.get("magna_carta", "device_port"))
             if pos.start_connection() is True:
                 value = pos.get_last_transaction_result()
+                # BUG? what happens if there is an Exception during Response_ACK? Should this be delayed to the end of the function? Rewrite "return False"-logic?
                 pos.response_ack()
             pos.close()
         except (magpos.serial.SerialException, magpos.ConnectionTimeoutError):