Update librime and glog; add librime-predict #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocka
changed the title
wxyzh
pushed a commit
to wxyzh/f5a-prebuilder
that referenced
this pull request
Apr 9, 2024
Co-authored-by: Rocka <i@rocka.me>
mokapsing
pushed a commit
to mokapsing/f5a-prebuilder
that referenced
this pull request
Apr 10, 2024
Co-authored-by: Rocka <i@rocka.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glog ref: google/glog@v0.6.0...v0.7.0
For librime-predict, I followed its README and used predict.db from https://github.com/rime/librime-predict/releases on f5m. It works but the model is for traditional Chinese so only suitable for luna_pinyin. I don't think you want to bundle it. I know someone has trained their own model. Just let user copy themselves.