feat: Add milvus package to release image & option to Operator (#4870)

feast-dev · Dec 30, 2024 · ef724b6 · ef724b6
1 parent 30ed749
commit ef724b6
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/infra/feast-operator/api/v1alpha1/featurestore_types.go b/infra/feast-operator/api/v1alpha1/featurestore_types.go
@@ -154,7 +154,7 @@ type OnlineStoreFilePersistence struct {
 
 // OnlineStoreDBStorePersistence configures the DB store persistence for the offline store service
 type OnlineStoreDBStorePersistence struct {
-	// +kubebuilder:validation:Enum=snowflake.online;redis;ikv;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase
+	// +kubebuilder:validation:Enum=snowflake.online;redis;ikv;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase;milvus
 	Type string `json:"type"`
 	// Data store parameters should be placed as-is from the "feature_store.yaml" under the secret key. "registry_type" & "type" fields should be removed.
 	SecretRef corev1.LocalObjectReference `json:"secretRef"`
@@ -178,6 +178,7 @@ var ValidOnlineStoreDBStorePersistenceTypes = []string{
 	"elasticsearch",
 	"qdrant",
 	"couchbase",
+	"milvus",
 }
 
 // LocalRegistryConfig configures the deployed registry service

diff --git a/infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml b/infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml
@@ -749,6 +749,7 @@ spec:
                                 - elasticsearch
                                 - qdrant
                                 - couchbase
+                                - milvus
                                 type: string
                             required:
                             - secretRef
@@ -2020,6 +2021,7 @@ spec:
                                     - elasticsearch
                                     - qdrant
                                     - couchbase
+                                    - milvus
                                     type: string
                                 required:
                                 - secretRef

diff --git a/infra/feast-operator/dist/install.yaml b/infra/feast-operator/dist/install.yaml
@@ -757,6 +757,7 @@ spec:
                                 - elasticsearch
                                 - qdrant
                                 - couchbase
+                                - milvus
                                 type: string
                             required:
                             - secretRef
@@ -2028,6 +2029,7 @@ spec:
                                     - elasticsearch
                                     - qdrant
                                     - couchbase
+                                    - milvus
                                     type: string
                                 required:
                                 - secretRef

diff --git a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile
@@ -1,7 +1,7 @@
 FROM python:3.11-slim-bullseye
 
 RUN pip install --no-cache-dir pip --upgrade
-RUN pip install --no-cache-dir "feast[aws,gcp,snowflake,redis,go,mysql,postgres,opentelemetry,grpcio,k8s,duckdb]"
+RUN pip install --no-cache-dir "feast[aws,gcp,snowflake,redis,go,mysql,postgres,opentelemetry,grpcio,k8s,duckdb,milvus]"
 
 
 RUN apt update && apt install -y -V ca-certificates lsb-release wget && \