Add namespace and fix IE9 location.origin bug #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@z-vr looks like I completely missed this pull request. I'll check this out ASAP. Sorry! |
|
@refractalize Hi, that's ok. We've been using this fork master...z-vr:master -- one of the important features is |
| @@ -9,13 +9,13 @@ function messageId() { | |||
| return Date.now() + ':' + messageIndex++; | |||
| } | |||
|
|
|||
| var socket = io(location.host, { | |||
| var socket = io('/karma-server-side', { | |||
There was a problem hiding this comment.
hi - just merging this now. what was the purpose of changing the namespace?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window.originis not available in IE9 which makes communication impossible (Doesn't seem to work with IE9 #6)/karma-server-sidenamespace