Merge pull request #5 from felsokning/hotfix/TLS_Version_Issue

Fixing TLS Version in HttpBase Until Bug Can Be Addressed

.github/workflows/build-and-publish-to-nuget.yaml

@@ -37,6 +37,6 @@ jobs:
       - name: Adding markdown to build summary
         run: cat code-coverage-results.md >> $GITHUB_STEP_SUMMARY
       - name: .NET Pack
-        run: dotnet pack /p:Version=${{ github.event.release.tag_name }}
+        run: dotnet pack --configuration Debug /p:Version=${{ github.event.release.tag_name }}
       - name: Push to NuGet
         run: dotnet nuget push "**/*.nupkg" --api-key ${{ secrets.NUGET_API_TOKEN }} --source https://api.nuget.org/v3/index.json

Felsökning.Tests/HttpBaseTests.cs

@@ -0,0 +1,15 @@
+namespace Felsökning.Tests
+{
+    [TestClass]
+    public class HttpBaseTests
+    {
+        [TestMethod]
+        public async Task TestTlsVersions()
+        {
+            var sut = new HttpBase(HttpVersion.Version11, "Felsökning.Tests");
+
+            var exception = await Assert.ThrowsExceptionAsync<HttpRequestException>(async () => await sut.HttpClient.GetStringAsync("https://api.nationaltransport.ie/gtfsr/v2/TripUpdates?format=json"));
+            exception.Should().BeOfType<HttpRequestException>();
+        }
+    }
+}

Felsökning/HttpBase.cs

@@ -19,8 +19,9 @@ public class HttpBase : IDisposable
         public HttpBase(Version httpVersion, [Optional] string productInfoString)
         {
             var httpClientHandler = new HttpClientHandler()
-            { 
-                SslProtocols = SslProtocols.Tls13 
+            {
+                //SslProtocols.Tls13
+                SslProtocols = SslProtocols.Tls12
             };
 
             HttpClient = new HttpClient(httpClientHandler)