On clean update binary proxies

[amanjeev]

This was quick when you figure out where things are already done. A small one.

Testing

Start with a clean state.json.

For best results, delete the entire criticalup installation directory.

Install project 1

Use this manifest to install first project. Name this file project1.toml.

manifest-version = 1

[products.ferrocene]
release = "stable-24.11.0"
packages = [
    "cargo-${rustc-host}",
    "rustc-${rustc-host}",
    "flip-link-${rustc-host}",
]

Install project 2

Use this manifest to install first project. Name this file project2.toml.

This is same as above except flip-link is removed.

manifest-version = 1

[products.ferrocene]
release = "stable-24.11.0"
packages = [
    "cargo-${rustc-host}",
    "rustc-${rustc-host}",
]

Check binary proxies

You should see following binary proxies:

• cargo
• flip-link
• rustc
• rustdoc
• rust-gdb
• rust-gdbgui
• rust-lldb

Remove project 1

cargo run -q remove --project project1.toml.

This will remove the project from state file but won't clean up. For cleaning up, we run clean command next.

Run clean command

cargo run -q clean

You should see flip-link binary proxy removed; you should see the following binary proxies.

• cargo
• rustc
• rustdoc
• rust-gdb
• rust-gdbgui
• rust-lldb

This should show that only flip-link was removed because all other binary proxies were still being referenced by another installation (project 2).

[amanjeev]

@Hoverbear Added a little check to make sure what is passed is not a dir.

[Hoverbear]

Rest looks good

[Hoverbear]

bors merge

[bors-ferrocene]

Build succeeded:

• CI build successful