Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger improvements #434

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Ledger improvements #434

merged 3 commits into from
Jan 27, 2025

Conversation

sh-wallet
Copy link
Collaborator

@sh-wallet sh-wallet commented Jan 27, 2025

Proposed Changes

  1. Redesigned the permission page UI.
  2. Handled the auto-detect permission failure error on the sign modal: this issue occurs when the user manually resets the permission or upgrades the Ledger firmware, resulting in the loss of USB permissions.
  3. Mobile ledger migration support

Linked Issues

#423 (comment)

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease
  • I have added/updated the documentation

Further comments

[if this is a relatively large or complex change, kick off a discussion by explaining why you chose the solution you did, what alternatives you considered, etc...]

@sh-wallet sh-wallet force-pushed the ledger-improvements branch from e70aa87 to 3ac8953 Compare January 27, 2025 09:21
@sh-wallet sh-wallet enabled auto-merge (squash) January 27, 2025 09:22
@sh-wallet sh-wallet merged commit 0d79c4b into main Jan 27, 2025
2 checks passed
@sh-wallet sh-wallet deleted the ledger-improvements branch January 27, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants