Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable fail-on-cache-miss in Docker workflow #228

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/docker-matrix-wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ jobs:

- name: generate requierementsfile for extra requirements
run: |
#echo "cryptography" >> requirements_extra.txt
echo "cryptography" >> requirements_extra.txt
echo "pyaml" >> requirements_extra.txt


Expand Down Expand Up @@ -265,7 +265,7 @@ jobs:
action: actions/cache/restore@v4
with: |
path: ./wheelhouse
fail-on-cache-miss: true
fail-on-cache-miss: false
key: wheels-${{ env.IMAGE_VERSION }}-${{ hashFiles('requirements.txt') }}

- name: Init wheels cache
Expand Down
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@


# Building wheels for later useage
FROM python:3.12.5@sha256:11aa4b620c15f855f66f02a7f3c1cd9cf843cc10f3edbcf158e5ebcd98d1f549 as builder-base
FROM python:3.12.5@sha256:11aa4b620c15f855f66f02a7f3c1cd9cf843cc10f3edbcf158e5ebcd98d1f549 AS builder-base


RUN <<eot
Expand All @@ -18,7 +18,7 @@
ENV PATH="/root/.cargo/bin:${PATH}"

# used for building wheels out of requirements.txt
FROM builder-base as w-builder
FROM builder-base AS w-builder

ARG TARGETOS
ARG TARGETARCH
Expand All @@ -44,7 +44,7 @@


# base fhempy will be installed
FROM python:3.12.5@sha256:11aa4b620c15f855f66f02a7f3c1cd9cf843cc10f3edbcf158e5ebcd98d1f549 as base

Check warning on line 47 in Dockerfile

View workflow job for this annotation

GitHub Actions / prepare_build

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 47 in Dockerfile

View workflow job for this annotation

GitHub Actions / prepare_build

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 47 in Dockerfile

View workflow job for this annotation

GitHub Actions / prepare_build

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 47 in Dockerfile

View workflow job for this annotation

GitHub Actions / prepare_build

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 47 in Dockerfile

View workflow job for this annotation

GitHub Actions / prepare_build

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

RUN apt update && \
apt install dbus python-dbus-dev curl -y --no-install-recommends \
Expand All @@ -61,7 +61,7 @@
eot

# image for fhempy modules (final stage) module will be installed here
FROM base as runtime
FROM base AS runtime

WORKDIR /usr/src/apps

Expand Down
Loading