Add tests

fiddleheadjs · Feb 1, 2023 · e98d633 · e98d633
1 parent 8d14984
commit e98d633
Show file tree

Hide file tree

Showing 21 changed files with 135 additions and 44 deletions.
diff --git a/lib/core/cjs.development.js b/lib/core/cjs.development.js
@@ -1480,12 +1480,11 @@ let _reconcileOnlyChildOfDynamicNode = (current, alternate, isRenderRoot) => {
         newContent = current.type_(current.props_);
         flushCurrentlyProcessing();
     } catch (error) {
-        // Must flush currently processing info right after an error occurred,
-        // because catchError may cause re-render at a higher level component
-        // TODO: Add tests for this case
+        newContent = null;
+        // Must flush currently processing info before catchError(),
+        // because catchError() may cause re-render at a higher level component
         flushCurrentlyProcessing();
         catchError(error, current);
-        newContent = null;
     }
 
     let newChild = createVNodeFromContent(newContent);

diff --git a/lib/core/cjs.development.legacy.js b/lib/core/cjs.development.legacy.js
@@ -1458,12 +1458,11 @@ var _reconcileOnlyChildOfDynamicNode = function _reconcileOnlyChildOfDynamicNode
     newContent = current.type_(current.props_);
     flushCurrentlyProcessing();
   } catch (error) {
-    // Must flush currently processing info right after an error occurred,
-    // because catchError may cause re-render at a higher level component
-    // TODO: Add tests for this case
+    newContent = null; // Must flush currently processing info before catchError(),
+    // because catchError() may cause re-render at a higher level component
+
     flushCurrentlyProcessing();
     catchError(error, current);
-    newContent = null;
   }
 
   var newChild = createVNodeFromContent(newContent);

diff --git a/lib/core/cjs.development.legacy.min.js b/lib/core/cjs.development.legacy.min.js
diff --git a/lib/core/cjs.development.min.js b/lib/core/cjs.development.min.js
diff --git a/lib/core/cjs.production.js b/lib/core/cjs.production.js
@@ -1480,12 +1480,11 @@ let _reconcileOnlyChildOfDynamicNode = (current, alternate, isRenderRoot) => {
         newContent = current.type_(current.props_);
         flushCurrentlyProcessing();
     } catch (error) {
-        // Must flush currently processing info right after an error occurred,
-        // because catchError may cause re-render at a higher level component
-        // TODO: Add tests for this case
+        newContent = null;
+        // Must flush currently processing info before catchError(),
+        // because catchError() may cause re-render at a higher level component
         flushCurrentlyProcessing();
         catchError(error, current);
-        newContent = null;
     }
 
     let newChild = createVNodeFromContent(newContent);

diff --git a/lib/core/cjs.production.legacy.js b/lib/core/cjs.production.legacy.js
@@ -1458,12 +1458,11 @@ var _reconcileOnlyChildOfDynamicNode = function _reconcileOnlyChildOfDynamicNode
     newContent = current.type_(current.props_);
     flushCurrentlyProcessing();
   } catch (error) {
-    // Must flush currently processing info right after an error occurred,
-    // because catchError may cause re-render at a higher level component
-    // TODO: Add tests for this case
+    newContent = null; // Must flush currently processing info before catchError(),
+    // because catchError() may cause re-render at a higher level component
+
     flushCurrentlyProcessing();
     catchError(error, current);
-    newContent = null;
   }
 
   var newChild = createVNodeFromContent(newContent);

diff --git a/lib/core/cjs.production.legacy.min.js b/lib/core/cjs.production.legacy.min.js
diff --git a/lib/core/cjs.production.min.js b/lib/core/cjs.production.min.js
diff --git a/lib/core/esm.development.js b/lib/core/esm.development.js
@@ -1476,12 +1476,11 @@ let _reconcileOnlyChildOfDynamicNode = (current, alternate, isRenderRoot) => {
         newContent = current.type_(current.props_);
         flushCurrentlyProcessing();
     } catch (error) {
-        // Must flush currently processing info right after an error occurred,
-        // because catchError may cause re-render at a higher level component
-        // TODO: Add tests for this case
+        newContent = null;
+        // Must flush currently processing info before catchError(),
+        // because catchError() may cause re-render at a higher level component
         flushCurrentlyProcessing();
         catchError(error, current);
-        newContent = null;
     }
 
     let newChild = createVNodeFromContent(newContent);

diff --git a/lib/core/esm.development.legacy.js b/lib/core/esm.development.legacy.js
@@ -1453,12 +1453,11 @@ var _reconcileOnlyChildOfDynamicNode = function _reconcileOnlyChildOfDynamicNode
     newContent = current.type_(current.props_);
     flushCurrentlyProcessing();
   } catch (error) {
-    // Must flush currently processing info right after an error occurred,
-    // because catchError may cause re-render at a higher level component
-    // TODO: Add tests for this case
+    newContent = null; // Must flush currently processing info before catchError(),
+    // because catchError() may cause re-render at a higher level component
+
     flushCurrentlyProcessing();
     catchError(error, current);
-    newContent = null;
   }
 
   var newChild = createVNodeFromContent(newContent);