improve tracing data and include lotus tracing #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrist
changed the title
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
========================================
- Coverage 32.9% 32.9% -0.1%
========================================
Files 40 40
Lines 3724 3771 +47
========================================
+ Hits 1228 1241 +13
- Misses 2360 2391 +31
- Partials 136 139 +3 |
|
Just saw filecoin-project/lotus#7646 is landing soon, this will be great for further tracing through the stores. |
iand
changed the title
frrist
force-pushed
the
frrist/make-tracing-work
branch
2 times, most recently
from
fcdd908 to
c0fe2b6
Compare
- clean up traceing flags and setup code
- attributes iff span is recording - env vars for config tracing
frrist
force-pushed
the
frrist/make-tracing-work
branch
from
c0fe2b6 to
1472450
Compare
frrist
commented
Jan 17, 2022
| @@ -91,39 +91,28 @@ func main() { | |||
| Destination: &commands.VisorLogFlags.LogLevelNamed, | |||
| }, | |||
| &cli.BoolFlag{ | |||
| Name: "tracing", | |||
There was a problem hiding this comment.
@placer14 heads up, this changes the flags for setting up tracing a little bit. Details of the change are in this file.
frrist
added a commit
that referenced
this pull request
Jan 19, 2022
* chore: update opentelemetry and support traces from lotus * chore: clean up tracing flags and setup code * chore: remove redundant trace from actorstate task * polish: instrument TipSetIndexer spans * polish: instrument walker spans * polish: instrument watcher spans * polish: instrument GetExecutedAndBlockMessagesForTipset spans * polish: allow docker-compose jaeger to work by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows lily to send traces produced by lotus and improves the quality of lily's tracing data. Below is an example of a walk trace. The trace include the spans implemented in lily as well as the spans from lotus (e.g.
vm.Invoke)