Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clear up release process docs #1983

Merged
merged 2 commits into from
Feb 3, 2024
Merged

doc: clear up release process docs #1983

merged 2 commits into from
Feb 3, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Feb 1, 2024

Is this better? Seems more accurate to current flow.

@rvagg rvagg requested review from Stebalien and rjan90 February 1, 2024 01:14
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f28593a) 75.55% compared to head (60ca186) 75.51%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1983      +/-   ##
==========================================
- Coverage   75.55%   75.51%   -0.04%     
==========================================
  Files         158      158              
  Lines       15600    15600              
==========================================
- Hits        11787    11781       -6     
- Misses       3813     3819       +6     

see 3 files with indirect coverage changes

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rvagg rvagg requested a review from Stebalien February 2, 2024 06:16
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit then let's merge this. Thanks!

@Stebalien Stebalien merged commit d3913e4 into master Feb 3, 2024
12 checks passed
@Stebalien Stebalien deleted the rvagg/release branch February 3, 2024 00:05
@Stebalien
Copy link
Member

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants