Support for pyodide 0.27.1, including pyarrow + pandas #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjakubowski
force-pushed
the
bugfix/pyodide-0.27
branch
2 times, most recently
from
5e18b93 to
5e5eb22
Compare
tomjakubowski
commented
Jan 23, 2025
| @@ -168,7 +168,14 @@ async function focus_package() { | |||
| message: "Focus NPM package(s)?", | |||
| default: () => { | |||
| if (CONFIG["PACKAGE"]) { | |||
| return CONFIG["PACKAGE"].split(","); | |||
| const packages = CONFIG["PACKAGE"].split(","); | |||
There was a problem hiding this comment.
to test this, runpnpm -w run setup, select perspective-pyodide. then run setup again. perspective-pyodide should be still selected in the menu.
previously the menu selected perspective-python on the second go - which made it easy to accidentally switch back to cpython
tomjakubowski
force-pushed
the
bugfix/pyodide-0.27
branch
2 times, most recently
from
e0b1bfc to
5e40a9e
Compare
Signed-off-by: Tom Jakubowski <tom@prospective.dev>
tomjakubowski
force-pushed
the
bugfix/pyodide-0.27
branch
2 times, most recently
from
6b1ab04 to
63ee460
Compare
- Switch to using global `CMAKE_CXX_FLAGS` to ensure every target we need to link, including all Arrow components, is built with Emscripten exceptions support. The build already does the same thing for wasm exceptions so it's at least more consistent now. - Add two regression tests to the pytest-pyodide suite for pyarrow and pandas examples, which were previously crashing due to inconsistent Emscripten exceptions support between the object files Signed-off-by: Tom Jakubowski <tom@prospective.dev>
Signed-off-by: Tom Jakubowski <tom@prospective.dev>
Signed-off-by: Tom Jakubowski <tom@prospective.dev>
tomjakubowski
force-pushed
the
bugfix/pyodide-0.27
branch
from
63ee460 to
5f8fdc3
Compare
|
I think that's a spurious test failure. I can't restart Actions runs in this repo, but I did do a manual dispatch on my fork: https://github.com/tomjakubowski/perspective/actions/runs/13041122245 |
texodus
approved these changes
Feb 2, 2025
| shell: bash | ||
| run: python -m playwright install | ||
| if: ${{ inputs.pyodide == 'true' }} | ||
|
|
| @@ -338,6 +338,15 @@ if(PSP_PYODIDE) | |||
| string(APPEND CMAKE_CXX_FLAGS "${RELOCATABLE_FLAGS}") | |||
| endif() | |||
|
|
|||
| if(PSP_PYODIDE) | |||
There was a problem hiding this comment.
I propose we set this for everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_CXX_FLAGSto ensure every target weneed to link, including all Arrow components, is built with Emscripten
exceptions support. The build already does the same thing for wasm
exceptions so it's at least more consistent now.
pandas examples, which were previously crashing due to inconsistent
Emscripten exceptions support between the object files
Also includes:
Pull Request Checklist
Discussions, this PR applies to. (N/A)