Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python): Implementation of Ollama plugin #1828

Merged
merged 2 commits into from
Feb 27, 2025
Merged

feat(python): Implementation of Ollama plugin #1828

merged 2 commits into from
Feb 27, 2025

Conversation

kirgrim
Copy link
Contributor

@kirgrim kirgrim commented Feb 4, 2025 •
edited
Loading

Added support for the ollama plugin in pythonic version of Genkit based on official library

Usage examples:

  • Added sample in py/samples/ollama/hello.pyfor the basic interaction with the llama model via Genkit

Checklist (if applicable):

@kirgrim kirgrim requested a review from yesudeep February 4, 2025 17:59
@kirgrim kirgrim added feature New feature or request P1 important bugs that need to be addressed python Python labels Feb 4, 2025
@github-actions github-actions bot added docs Improvements or additions to documentation config labels Feb 4, 2025
@kirgrim kirgrim force-pushed the hrymailo/feat/py-ollama-plugin branch from a642504 to 2fb8a54 Compare February 4, 2025 18:00
@kirgrim kirgrim marked this pull request as draft February 4, 2025 18:01
@kirgrim kirgrim force-pushed the hrymailo/feat/py-ollama-plugin branch from 2fb8a54 to 1304ae0 Compare February 5, 2025 15:47
@kirgrim kirgrim requested a review from Irillit February 5, 2025 15:48
@kirgrim kirgrim force-pushed the hrymailo/feat/py-ollama-plugin branch from 1304ae0 to 8d4c6d7 Compare February 5, 2025 15:55
@github-actions github-actions bot added the root label Feb 5, 2025
@kirgrim kirgrim marked this pull request as ready for review February 5, 2025 19:48
@kirgrim kirgrim force-pushed the hrymailo/feat/py-ollama-plugin branch from ed00f85 to b498e6f Compare February 5, 2025 20:05
@kirgrim kirgrim requested review from Irillit and pavelgj February 7, 2025 12:33
@kirgrim
Copy link
Contributor Author

kirgrim commented Feb 7, 2025

@Irillit @pavelgj please take a second look, if its fine - lets merge it

pavelgj
pavelgj reviewed Feb 7, 2025
View reviewed changes
@kirgrim kirgrim force-pushed the hrymailo/feat/py-ollama-plugin branch from b498e6f to 5714359 Compare February 22, 2025 15:34
@kirgrim kirgrim requested a review from pavelgj February 22, 2025 15:35
@kirgrim kirgrim force-pushed the hrymailo/feat/py-ollama-plugin branch 2 times, most recently from c87ad00 to aab8540 Compare February 24, 2025 15:46
@kirgrim kirgrim force-pushed the hrymailo/feat/py-ollama-plugin branch from aab8540 to 50e2a23 Compare February 25, 2025 11:26
@kirgrim kirgrim force-pushed the hrymailo/feat/py-ollama-plugin branch from 50e2a23 to 2280bef Compare February 26, 2025 13:54
@kirgrim kirgrim requested review from Irillit and pavelgj February 26, 2025 13:55
@kirgrim kirgrim force-pushed the hrymailo/feat/py-ollama-plugin branch 2 times, most recently from f594e4f to 2ef4a9c Compare February 26, 2025 13:58
Irillit
Irillit approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@Irillit Irillit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kirgrim kirgrim force-pushed the hrymailo/feat/py-ollama-plugin branch from 2ef4a9c to f5c4194 Compare February 26, 2025 15:43
@kirgrim kirgrim requested review from Irillit and pavelgj February 26, 2025 15:43
@kirgrim
Copy link
Contributor Author

kirgrim commented Feb 26, 2025

@pavelgj I am aware that we already have embedders API defined, but I would prefer to introduce it to Ollama as a next ticket to make things a bit more gradual: #2175

@kirgrim kirgrim force-pushed the hrymailo/feat/py-ollama-plugin branch 2 times, most recently from 3d68699 to 823657a Compare February 27, 2025 11:45
@kirgrim kirgrim force-pushed the hrymailo/feat/py-ollama-plugin branch from 823657a to 2cb1152 Compare February 27, 2025 11:47
@kirgrim kirgrim merged commit d50c8c5 into main Feb 27, 2025
7 checks passed
@kirgrim kirgrim deleted the hrymailo/feat/py-ollama-plugin branch February 27, 2025 13:12
kamilkorski
kamilkorski reviewed Feb 27, 2025
View reviewed changes
py/plugins/ollama/src/genkit/plugins/ollama/mixins.py
LOG = logging.getLogger(__name__)


class BaseOllamaModelMixin:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really a mixin or just a base class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Irillit Irillit Irillit approved these changes

@kamilkorski kamilkorski kamilkorski left review comments

@pavelgj pavelgj pavelgj approved these changes

@yesudeep yesudeep Awaiting requested review from yesudeep

Assignees
No one assigned
Labels
config docs Improvements or additions to documentation feature New feature or request P1 important bugs that need to be addressed python Python root
Projects
Genkit Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kirgrim @pavelgj @Irillit @kamilkorski