Quic: Revamp In-flight packet tracking #4103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhinvasara-jumptrading
force-pushed
the
akhin/tx_data_structs
branch
from
1d8ab70 to
3c46e30
Compare
| /* initialize free list of packet metadata */ | ||
| for( ulong j = 0; j < pkt_meta_array_sz; ++j ) { | ||
| fd_quic_pkt_meta_push_back( free, &pkt_meta_array[j] ); | ||
| #define FD_QUIC_MAX_INFLIGHT_LOW_ENC 20 |
There was a problem hiding this comment.
Maybe want a better way to do this?
lidatong
reviewed
Feb 6, 2025
akhinvasara-jumptrading
force-pushed
the
akhin/tx_data_structs
branch
from
3c46e30 to
7257e53
Compare
akhinvasara-jumptrading
changed the title
|
Tagging @ptaffet-jump to review the tmpl change |
akhinvasara-jumptrading
force-pushed
the
akhin/tx_data_structs
branch
from
7257e53 to
e9344d8
Compare
akhinvasara-jumptrading
force-pushed
the
akhin/tx_data_structs
branch
from
e9344d8 to
14e93e0
Compare
akhinvasara-jumptrading
force-pushed
the
akhin/tx_data_structs
branch
from
284793a to
917f05a
Compare
akhinvasara-jumptrading
force-pushed
the
akhin/tx_data_structs
branch
2 times, most recently
from
3f0bc26 to
70f82a5
Compare
akhinvasara-jumptrading
force-pushed
the
akhin/tx_data_structs
branch
4 times, most recently
from
7e0025e to
5d36836
Compare
ripatel-fd
reviewed
Feb 11, 2025
akhinvasara-jumptrading
force-pushed
the
akhin/tx_data_structs
branch
from
5d36836 to
ba606c0
Compare
akhinvasara-jumptrading
force-pushed
the
akhin/tx_data_structs
branch
from
ba606c0 to
7d11f4e
Compare
akhinvasara-jumptrading
force-pushed
the
akhin/tx_data_structs
branch
from
902a447 to
d16b01b
Compare
akhinvasara-jumptrading
force-pushed
the
akhin/tx_data_structs
branch
from
d16b01b to
3240c28
Compare
akhinvasara-jumptrading
force-pushed
the
akhin/tx_data_structs
branch
from
3240c28 to
b395294
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR abstracts the data structure used by fd_quic to track in-flight packets, and switches from a linked list to a treap. It adds a lower_bound query to the treap to aid.
test_quic_adversarial_acks can be used to compare performance of diff data structures under adversarial, heavily reordered, or well-ordered traffic. According to those results, this PR increases latency tolerably in the best case, but curbs it significantly in the worst case, particulary as the number of inflight packets scales.
Example:
Starting with 5k pkt_metas, removing 10 at a time. test_quic_adversarial describes the different cases
linked list:
Very adversarial: 46729 us
Reasonable reordering: 724 us
Happy case: 660 us
treap
Very adversarial: 3066 us
Reasonable reordering: 2124 us
Happy case: 1754 us