Quic: Ack overflow probes, 10x idle_timeout buffer #4188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
akhinvasara-jumptrading
force-pushed
the
akhin/ack_probe
branch
2 times, most recently
from
313c8c7 to
e906f57
Compare
akhinvasara-jumptrading
force-pushed
the
akhin/ack_probe
branch
from
e906f57 to
91712cd
Compare
|
Fix the commit message please |
akhinvasara-jumptrading
force-pushed
the
akhin/ack_probe
branch
from
91712cd to
a22bb2a
Compare
akhinvasara-jumptrading
force-pushed
the
akhin/ack_probe
branch
from
a22bb2a to
918742b
Compare
akhinvasara-jumptrading
changed the title
| @@ -945,7 +945,7 @@ dynamic_port_range = "8900-9000" | |||
| idle_timeout_millis = 10000 | |||
|
|
|||
| # Max delay for outgoing ACKs. | |||
| ack_delay_millis = 50 | |||
| ack_delay_millis = 25 | |||
There was a problem hiding this comment.
Why are we changing the max ack delay in the default.toml?
There was a problem hiding this comment.
Using this branch mostly for testing rn, but just worth noting 25 is what the QUIC spec recommends. Directionally, this may contribute to our under-delivery issue (although unlikely)
There was a problem hiding this comment.
I'm not sure we have an under-delivery issue :-)
But PRs that add tests or change testing behavior should not change production config, as a general rule.
akhinvasara-jumptrading
force-pushed
the
akhin/ack_probe
branch
from
a262bca to
82a9521
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds probe points related to ACK behavior, and a new metric for when the ACK buffer overflows.