Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark tests that return None as skipped #39

Merged
merged 2 commits into from
May 28, 2024
Merged

fix: mark tests that return None as skipped #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4524483
fix: mark tests that return None as skipped
0x0ece May 28, 2024
d542b4e
diff: use diff_effect_fn from harness ctx
0x0ece May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/test_suite/multiprocessing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,8 +365,12 @@ def build_test_results(results: dict[str, str | None]) -> tuple[int, dict | None

protobuf_structures[target] = instruction_effects

if protobuf_structures[globals.solana_shared_library] is None:
return 0, None

diff_effect_fn = globals.harness_ctx.diff_effect_fn
test_case_passed = all(
protobuf_structures[globals.solana_shared_library] == result
diff_effect_fn(protobuf_structures[globals.solana_shared_library], result)
for result in protobuf_structures.values()
)

Expand Down
3 changes: 3 additions & 0 deletions src/test_suite/test_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,10 +335,12 @@ def run_tests(
failed = 0
skipped = 0
failed_tests = []
skipped_tests = []
target_log_files = {target: None for target in shared_libraries}
for file_stem, status, stringified_results in test_case_results:
if stringified_results is None:
skipped += 1
skipped_tests.append(file_stem)
continue

for target, string_result in stringified_results.items():
Expand Down Expand Up @@ -377,6 +379,7 @@ def run_tests(
print(f"Passed: {passed}, Failed: {failed}, Skipped: {skipped}")
if verbose:
print(f"Failed tests: {failed_tests}")
print(f"Skipped tests: {skipped_tests}")


@app.command()
Expand Down
Loading