Merge branch 'ErrorCodesReview'

firefinancialservices · Feb 4, 2025 · 3edc9b6 · 3edc9b6
2 parents 7df5691 + 3de4708
commit 3edc9b6
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 14 deletions.
diff --git a/src/fire-business-api-v1.yaml b/src/fire-business-api-v1.yaml
@@ -177,7 +177,7 @@ paths:
     $ref: ./v2/paths/paymentrequests/update-paymentrequest.yaml
 
 webhooks:
-  Webhook:
+  webhook:
     $ref: ./webhooks/webhooks.yaml
 
 components:

diff --git a/src/v1/paths/accounts/accounts-by-ican.yaml b/src/v1/paths/accounts/accounts-by-ican.yaml
@@ -19,11 +19,11 @@ get:
         application/json:
           schema:
             $ref: '#/components/schemas/Account'
-      '400':
+    '400':
         $ref: '../../responses/unauthorised-error.yaml'
-      '401':
+    '401':
         $ref: '../../responses/unauthorised-error.yaml'
-      '403':
+    '403':
         $ref: '../../responses/unauthorised-error.yaml'
 
 
diff --git a/src/v1/paths/accounts/accounts.yaml b/src/v1/paths/accounts/accounts.yaml
@@ -42,9 +42,9 @@ post:
         application/json:
           schema:
             $ref: '#/components/schemas/Account'
-      '400':
+    '400':
         $ref: '../../responses/unauthorised-error.yaml'
-      '401':
+    '401':
         $ref: '../../responses/unauthorised-error.yaml'
-      '403':
+    '403':
         $ref: '../../responses/unauthorised-error.yaml'
diff --git a/src/v1/paths/apps/accesstokens.yaml b/src/v1/paths/apps/accesstokens.yaml
@@ -20,4 +20,8 @@ post:
           schema:
             $ref: '#/components/schemas/AccessToken'
     '400':
+      $ref: '../../responses/unauthorised-error.yaml'
+    '401':
+      $ref: '../../responses/unauthorised-error.yaml'
+    '403':
       $ref: '../../responses/unauthorised-error.yaml'
diff --git a/src/v1/paths/apps/apps.yaml b/src/v1/paths/apps/apps.yaml
@@ -13,12 +13,12 @@ get:
             type: array
             items:            
               $ref: '../../schemas/applications.yaml' 
-      '400':
-        $ref: '../../responses/unauthorised-error.yaml'
-      '401':
-        $ref: '../../responses/unauthorised-error.yaml'
-      '403':
-        $ref: '../../responses/unauthorised-error.yaml'
+    '400':
+      $ref: '../../responses/unauthorised-error.yaml'
+    '401':
+      $ref: '../../responses/unauthorised-error.yaml'
+    '403':
+      $ref: '../../responses/unauthorised-error.yaml'
 post:
   summary: Create an API Application
   description: This endpoint will create a new API Application on your Fire account with your chosen specified permissions. Please note that if there is no batch approval permissions included, the approval fields must be set to null.

diff --git a/src/webhooks/webhooks.yaml b/src/webhooks/webhooks.yaml
@@ -1,7 +1,6 @@
 post:
   summary: Test webhook response
   description: Webhooks allow you to be notified of events as they happen on your Fire accounts. The below sample response shows how a webhook from Fire will arrive at your server. See our 'API and webhooks' guide for more detailed information.
-  tags: API and Webhooks
   requestBody:
     required: true
     content: