WIP: Adding dynamic Node support #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuetloo
suggested changes
Jan 26, 2025
src/color.c
Outdated
| if (c & COLOR_HSV) { | ||
| return snprintf(name, length, "HSV(%ld, %ld/63, %ld/63, %ld/32)", | ||
| _getS(c), _getS(c), _getV(c), _getA(c)); | ||
| _getS(c), _getS(c), _getV(c), alpha); |
|
|
||
| BoxNode *state = ffx_sceneNode_getState(node); | ||
| state->size = size; | ||
|
|
There was a problem hiding this comment.
No, the default value is 0 (alloc zeros memory), so by default colours are fully-opaque black.
But this should definitely be mentioned in the docs. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing Scene Nodes are all the exact same size, with a maximum of 2 properties allowed per Node.
This has led to rather complex AnimationNode structures, since they require 4 properties, so currently 2 Nodes are added per animation, with a careful balance of values split between them.
This also means things like TextNodes cannot have a font property as property A is used for internal state and property B as a link to the actual text data.
This PR adds support for Nodes of arbitrary size, currently using the system
mallocandfree, but designed around substituting in custom implementations, so that more efficient options can be added in the future.This also adds support for destructors, which allow Nodes to clean-up after themselves when they are removed.
The Animation and Render passes also no longer depend on using the standard Node objects, allowing them to allocate and store custom state, which is cleaned up automatically when animations complete and render passes finish.