This repository has been archived by the owner on May 16, 2024. It is now read-only.
Karkakol/update version #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graszka22
reviewed
Feb 23, 2024
example/android/build.gradle
Outdated
| @@ -21,8 +21,11 @@ buildscript { | |||
| dependencies { | |||
| classpath("com.android.tools.build:gradle") | |||
| classpath('com.facebook.react:react-native-gradle-plugin') | |||
| classpath("org.jetbrains.kotlin:kotlin-gradle-plugin") | |||
| // classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version" | |||
example/babel.config.js
Outdated
| @@ -2,7 +2,7 @@ const path = require('path'); | |||
| module.exports = function (api) { | |||
| api.cache(true); | |||
| return { | |||
| presets: ['babel-preset-expo'], | |||
| presets: ['module:@react-native/babel-preset'], | |||
There was a problem hiding this comment.
because of upgrading RN to 0.73
example/ios/Podfile
Outdated
| @@ -66,7 +66,7 @@ target 'reactnativemembranewebrtcexample' do | |||
| # necessary for Mac Catalyst builds | |||
| :mac_catalyst_enabled => false | |||
| ) | |||
| __apply_Xcode_12_5_M1_post_install_workaround(installer) | |||
| # __apply_Xcode_12_5_M1_post_install_workaround(installer) | |||
example/tsconfig.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "extends": "expo/tsconfig.base", | |||
| "extends": "@react-native/typescript-config/tsconfig.json", | |||
There was a problem hiding this comment.
why this config instead of expo's?
There was a problem hiding this comment.
react native upgrade helper showed to chage that
package.json
Outdated
Comment on lines
46
to
50
| "@babel/core": "7.23.9", | ||
| "@babel/eslint-parser": "7.23.10", | ||
| "@babel/plugin-proposal-private-property-in-object": "7.21.11", | ||
| "@babel/preset-env": "7.23.9", | ||
| "@react-native/babel-preset": "0.73.21", |
There was a problem hiding this comment.
do we need all of this? shouldn't those packages be added by other packages?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.