Skip to content
This repository has been archived by the owner on Jul 8, 2024. It is now read-only.

feat: complete back-end #17

Merged
merged 974 commits into from
Feb 9, 2024
Merged

feat: complete back-end #17

merged 974 commits into from
Feb 9, 2024

Conversation

floriaaan
Copy link
Owner

  • http api (via gateway :50000)
  • microservices
  • CI/CD
  • terraform/k8s

@floriaaan
Copy link
Owner Author

floriaaan commented Aug 20, 2023 •
edited
Loading

  • add --minify to all JS microservices build scripts
  • replace @PierreLbg to @floriaaan in docker publish steps of ci/cd
  • unify lock-files (npm -> pnpm), including changes in Dockerfiles
  • reorganise Dockerfile steps
  • change all insecure settings (HTTPS/gRPC/Terraform Postgres connection) => secure

This was linked to issues Nov 27, 2023
gateway/order: order creation must handle stock management #20
Closed
Replace @PierreLbg to @floriaaan in docker publish steps of ci/cd #24
Closed
Unify lock-files (npm -> pnpm), including changes in Dockerfiles #25
Closed
Reorganise Dockerfile steps #26
Closed
Change all insecure settings (HTTPS/gRPC/Terraform Postgres connection) #27
Closed
Refactor reporting service #28
Closed
@floriaaan floriaaan added the good first issue Good for newcomers label Nov 27, 2023
@floriaaan floriaaan added this to the v0:server_ready milestone Nov 27, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

1 similar comment
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

2 similar comments
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 7, 2023
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023 •
edited
Loading

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 8 Bugs
Vulnerability E 12 Vulnerabilities
Security Hotspot E 62 Security Hotspots
Code Smell A 281 Code Smells

0.0% 0.0% Coverage
4.5% 4.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 9, 2024
View reviewed changes
services/delivery/log.docker-compose.yml
environment:
- DATABASE_URL=postgres://postgres:password@postgres:5432/postgres
- PORT=50021
- AMQP_URL=amqp://guest:guest@rabbitmq:5672

Check failure

Code scanning / SonarCloud

AMQP credentials should not be disclosed High

Make sure these Rabbit MQ credentials get revoked, changed, and removed from the code. See more on SonarCloud
docker-compose.log.yml
environment:
DATABASE_URL: postgres://postgres:password@log-postgres:5432/postgres
PORT: 50021
AMQP_URL: amqp://guest:guest@goodfood-rabbitmq:5672

Check failure

Code scanning / SonarCloud

AMQP credentials should not be disclosed High

Make sure these Rabbit MQ credentials get revoked, changed, and removed from the code. See more on SonarCloud
services/delivery/terraform/main.tf
version = "11"

ssl_enforcement_enabled = false
ssl_minimal_tls_version_enforced = "TLSEnforcementDisabled" // TODO: change to TLS1_2

Check failure

Code scanning / SonarCloud

Weak SSL/TLS protocols should not be used High

Change this code to disable support of older TLS versions. See more on SonarCloud
services/log/terraform/main.tf
version = "11"

ssl_enforcement_enabled = false
ssl_minimal_tls_version_enforced = "TLSEnforcementDisabled" // TODO: change to TLS1_2

Check failure

Code scanning / SonarCloud

Weak SSL/TLS protocols should not be used High

Change this code to disable support of older TLS versions. See more on SonarCloud
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

62 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
4.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

2 similar comments
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
76 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
3.6% Duplication on New Code (required ≤ 3%)
E Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@floriaaan floriaaan marked this pull request as ready for review February 9, 2024 02:14
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
76 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
3.6% Duplication on New Code (required ≤ 3%)
E Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

1 similar comment
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
76 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
3.6% Duplication on New Code (required ≤ 3%)
E Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
76 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
3.6% Duplication on New Code (required ≤ 3%)
E Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
76 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
3.6% Duplication on New Code (required ≤ 3%)
E Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
76 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
3.6% Duplication on New Code (required ≤ 3%)
E Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

5 similar comments
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
76 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
3.6% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
76 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
3.6% Duplication on New Code (required ≤ 3%)
E Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@floriaaan floriaaan merged commit d35d012 into main Feb 9, 2024
49 of 52 checks passed
floriaaan added a commit that referenced this pull request Feb 9, 2024
@floriaaan
Merge pull request #17 from floriaaan/dev
397aa95 
feat: complete back-end
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Anatole-Godard Anatole-Godard Anatole-Godard approved these changes

@PierreLbg PierreLbg PierreLbg approved these changes

Assignees

@floriaaan floriaaan

@Anatole-Godard Anatole-Godard

@PierreLbg PierreLbg

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v0:server_ready
3 participants
@floriaaan @Anatole-Godard @PierreLbg