Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wiki migration] Add static images for flutter/flutter/docs/ #246

Merged
merged 5 commits into from
May 20, 2024

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented May 20, 2024

This adds all of the images that are embedded in the flutter/flutter wiki, which is being migrated to flutter/flutter/docs/.
Part of flutter/flutter#145009

I needed to make a few other trivial updates for CI to pass, filed flutter/flutter#148709 to follow up on the ignore I placed on ButtonBar.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@@ -34,6 +34,7 @@ class CardDiagram extends StatelessWidget with DiagramMetadata {
subtitle: Text('Music by Julie Gable. Lyrics by Sidney Stein.'),
),
ButtonBar(
// ignore: deprecated_member_use
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed flutter/flutter#148709 for follow up

Copy link

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks merged commit bdd0068 into flutter:main May 20, 2024
2 checks passed
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 21, 2024
This sorts the wiki pages owned by the Infra team in the docs/ directory as planned in [flutter.dev/go/migrate-flutter-wiki-spreadsheet](https://docs.google.com/spreadsheets/d/1x65189ZBdNiLRygpUYoU08pwvXD4M-Z157c6pm8deGI/edit?usp=sharing) 

It also adds the team-infra label to the bot for future PRs.

Image assets were checked in here: flutter/assets-for-api-docs#246

Changes to the content were only updating links. The remaining wiki links will be updated after the rest of the pages are relocated, the original wiki links still work in the meantime.

Part of #145009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants