Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Card diagram to replace deprecated ButtonBar #248

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Update Card diagram to replace deprecated ButtonBar #248

merged 1 commit into from
Jun 14, 2024

Conversation

TahaTesser
Copy link
Member

fixes Migrate ButtonBar use in assets-for-api-docs/packages/diagrams/lib/src/card.dart

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@TahaTesser TahaTesser requested a review from Piinks June 12, 2024 08:53
Piinks
Piinks approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 14, 2024
@auto-submit auto-submit bot merged commit 90be9bc into flutter:main Jun 14, 2024
2 checks passed
@TahaTesser TahaTesser deleted the update_card_diagram branch June 14, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate ButtonBar use in assets-for-api-docs/packages/diagrams/lib/src/card.dart
2 participants
@TahaTesser @Piinks