Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a pubspec and platform runners #250

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Aug 5, 2024

Description

This updates a pubspec, all of the platform runners in the two packages that have platform directories.

The diagrams are updated separately in #251 including the contents of this change.

@gspencergoog gspencergoog changed the title Update pubspec, boilerplate, and diagrams Update a pubspec and platform runners Aug 5, 2024
@gspencergoog gspencergoog requested a review from goderbauer August 5, 2024 21:06
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@@ -1,71 +1,44 @@
// Copyright 2013 The Flutter Authors. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and elsewhere: Do we need to keep these license headers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license check doesn't fail, and they're all in the generated code. I added them back in already to the ones that failed the license check. I'm assuming no.

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2024
@auto-submit auto-submit bot merged commit 3711ff2 into flutter:main Aug 5, 2024
2 checks passed
auto-submit bot pushed a commit that referenced this pull request Aug 5, 2024
## Description

This PR updates the diagrams using the latest Flutter from the main channel, including the changes in #250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants