Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iOS and Android docs for flavors. #11709

Merged
merged 7 commits into from
Feb 13, 2025

Conversation

antfitch
Copy link
Contributor

@antfitch antfitch commented Feb 11, 2025

Description of what this PR is changing or adding, and why:

  • We now have flavors.md (Android) and flavors-ios.md (iOS and macOS)
  • Moved iOS workflow from flavors.md to flavors-ios.md
  • Both documents now focus on the build settings 'production' and 'staging' flavors instead of 'free' and 'premium'.
  • I have made minimal changes to the Android workflow in this PR and have focused on just making the general wording we use the same for Android and iOS. After this CL is submitted, I'll create a PR to update the Android workflow.
  • @Sfshaza I tried something new with code samples. I added a title above each of them to make it clear where a change needs to be made (console, podfile, etc). It helped ground me, but it might be overkill. Go ahead and remove titles if you feel they aren't needed.
  • @vashworth, can you check my iOS and macOS changes?
  • @reidbaker, can you check my terminology changes for Android. Ignore everything else. I'll have more updates in the next PR, which will be specifically for Android.

Issues fixed by this PR (if any):

I'll add the list to the next PR. There are a lot of them.

PRs or commits this PR depends on (if any):

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@antfitch antfitch requested review from sfshaza2, parlough, jmagman and a team as code owners February 11, 2025 22:07
@antfitch antfitch self-assigned this Feb 11, 2025
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Feb 11, 2025

Visit the preview URL for this PR (updated for commit 711471b):

https://flutter-docs-prod--pr11709-flavors-ios-guide-fkp7norr.web.app

@antfitch antfitch requested a review from vashworth February 12, 2025 00:04
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!! lgtm

Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antfitch!

@antfitch antfitch merged commit fd89bdc into flutter:main Feb 13, 2025
9 checks passed
@antfitch antfitch linked an issue Mar 7, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

☔ Flavors guide refactor
6 participants