-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flavors guide for Android. #11758
Conversation
Visit the preview URL for this PR (updated for commit 5b81fbd): https://flutter-docs-prod--pr11758-flavors-android-refactor-7l80oixl.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than one comment, lgtm! Next, why isn't the build happy?
src/content/deployment/flavors.md
Outdated
`Flavors s...`. | ||
|
||
* To see more information for `Flavors p...` or | ||
`Flavors s...`, hold down the mouse over one of them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wording troubles me. Isn't it more correct to say "hover over one of them and right-click the mouse button to bring up the menu. Select App info" or something like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that. Just did a quick look around and updated this to match what I'm seeing elsewhere.
To see more information for Flavors p...
or
Flavors s...
, long-press the icon for one of them
and and select App info
.
Ah, a section in this page has been renamed, breaking anchors in two other pages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a couple fixes, lgtm. I'll go ahead and approve, but please fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description of what this PR is changing or adding, and why:
This is a refactor of the Android Flavors guide that addresses several developer requests, including steps to customize the app name and app icons.
Issues fixed by this PR (if any):
Fixes: #11591 #11060 #10713 #10309 #10164 #9976 #9360 #9359 #9309 #8743 #8746 #8238
PRs or commits this PR depends on (if any):
This is part of a larger cleanup effort for the flavors documentation. The first part of this cleanup addressed our iOS and macOS docs for flavors. This was the final part of the cleanup.
Presubmit checklist