Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flavors guide for Android. #11758

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

antfitch
Copy link
Contributor

@antfitch antfitch commented Feb 28, 2025

Description of what this PR is changing or adding, and why:

This is a refactor of the Android Flavors guide that addresses several developer requests, including steps to customize the app name and app icons.

Issues fixed by this PR (if any):

Fixes: #11591 #11060 #10713 #10309 #10164 #9976 #9360 #9359 #9309 #8743 #8746 #8238

PRs or commits this PR depends on (if any):

This is part of a larger cleanup effort for the flavors documentation. The first part of this cleanup addressed our iOS and macOS docs for flavors. This was the final part of the cleanup.

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@antfitch antfitch requested review from sfshaza2, parlough, jmagman and a team as code owners February 28, 2025 23:22
@antfitch antfitch marked this pull request as draft February 28, 2025 23:22
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Feb 28, 2025

Visit the preview URL for this PR (updated for commit 5b81fbd):

https://flutter-docs-prod--pr11758-flavors-android-refactor-7l80oixl.web.app

@antfitch antfitch marked this pull request as ready for review February 28, 2025 23:29
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one comment, lgtm! Next, why isn't the build happy?

`Flavors s...`.

* To see more information for `Flavors p...` or
`Flavors s...`, hold down the mouse over one of them
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording troubles me. Isn't it more correct to say "hover over one of them and right-click the mouse button to bring up the menu. Select App info" or something like that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. Just did a quick look around and updated this to match what I'm seeing elsewhere.

To see more information for Flavors p... or
Flavors s..., long-press the icon for one of them
and and select App info.

@sfshaza2
Copy link
Contributor

sfshaza2 commented Mar 3, 2025

Ah, a section in this page has been renamed, breaking anchors in two other pages.

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a couple fixes, lgtm. I'll go ahead and approve, but please fix.

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit 1c2d97c into flutter:main Mar 3, 2025
9 checks passed
@antfitch antfitch self-assigned this Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

☔ Flavors guide refactor
3 participants