dws: rabbit config file support #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: a number of rabbit configuration options, such as the maximum size of file system users can request, are set by command-line options to the coral2-dws service. Move the file system size options to a config file and make coral2-dws read from it. Drop the command-line options.
Problem: a number of rabbit configuration options, such as the number of nnfdatamovement resources to save and whether or not to restrict the creation of persistent file systems to the instance owner, are set by command-line options to the coral2-dws service. Move those parameters to a config file and drop the command-line options.
Problem: the option to disable the draining of compute nodes that lose connection with their local rabbit is set by a command-line option to the coral2-dws service. It should a config file option. Move the draining option to a config file and make coral2-dws read from it. Drop the command-line option.
Problem: the coral2_dws script has a command-line option to set the path of the file from which it reads JGF for the rabbit resources it will operate. However, that is unnecessary and unhelpful because it could instead fetch the `resource.R` KVS key, which is a more reliable option. Drop the command-line argument and make the script read from the KVS.
Problem: a function receives an argparse Namespace object with a number of variables set on it, but only uses two of them. Pass the two variables the function needs rather than the whole namespace object.
Problem: flux-coral2-dws takes an optional flag to set the timeout after which it kills jobs whose workflows are stuck in TransientCondition. However, it should a config file option. Make coral2-dws read the parameter from the `rabbit` table in the config. Drop the command-line option.
Problem: flux-coral2-dws takes an optional flag to set the path to the kubeconfig file for it to use. However, it should a config file option. Make coral2-dws read the parameter from the `rabbit` table in the config. Drop the command-line option.
jameshcorbett
force-pushed
the
rabbit-configfile
branch
from
459db7c to
3c795e6
Compare
Problem: there are no checks to ensure that the rabbit config table is valid. Add some simple validation.
jameshcorbett
force-pushed
the
rabbit-configfile
branch
from
3c795e6 to
cfc450d
Compare
cmoussa1
approved these changes
Nov 5, 2024
|
Thanks! Setting MWP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves a bunch of
coral2_dws.pycommand-line arguments to a[rabbit]table in the Flux config.See also flux-framework/flux-docs#286 for a description of what the config file should look like.
Fixes #220.