Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more glossary terms #191

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Add more glossary terms #191

merged 2 commits into from
Feb 10, 2023

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Feb 1, 2023

Some were listed in #186, some weren't. Just trying to fill it out more.

@chu11 chu11 force-pushed the more_glossary branch 3 times, most recently from d8fc2c0 to 89f2edf Compare February 1, 2023 23:39
glossary.rst Outdated
Eventlogs are used to record job events, capture standard I/O streams,
and record resource status changes.
**Flux Shell**
A component of Flux which manages the startup and execution of user jobs. You
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A component of Flux which manages the startup and execution of user jobs. You
A component of Flux that manages the startup and execution of user jobs. You

glossary.rst Outdated
.. _job_queue:

**Queue**
A container for a set of jobs in priority order. Queues may differ in what
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some might read this as "linux container" but I don't think that's what you mean. Is there another term we can use?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. I used "container" b/c that's what we use in the RFC. Doing nothing more than googling "what is a job queue", first description seems to use "data structure", which I don't think is quite right for this context.

Will ponder, perhaps could re-word the whole thing in a different way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something simple and stupid like a list? Or another synonym for queue?

Copy link
Member Author

@chu11 chu11 Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of the synonyms spoke to me (vessel, receptacle, ...). As I went for a walk, "data structure" began sounding better to me.

"A scheduling job management data structure that contains sets of jobs in priority order."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went for a walk, you say? I have a song for you! https://youtu.be/dZX6Q-Bj_xg

I think data structure sounds ok too, at least I won't confuse it with "those other container things."

glossary.rst Outdated
**Queue**
A container for a set of jobs in priority order. Queues may differ in what
resources are assigned to them, which users are allowed to submit to them, and
what defaults/limits may exist for them. Often may be called a "job queue".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
what defaults/limits may exist for them. Often may be called a "job queue".
what defaults/limits may exist for them. Often may be called a "job queue."

glossary.rst Outdated
**Queue Enable/Disable/Start/Stop**
In Flux, the terms "enable"/"disable" are used to describe if jobs can be
submitted to a queue. The terms "start"/"stop" are used to describe if jobs
can be executed. Under normal operations, a queue is "enabled"/"started",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
can be executed. Under normal operations, a queue is "enabled"/"started",
can be executed. Under normal operations, a queue is "enabled"/"started,"

glossary.rst Outdated
submitted to a queue. The terms "start"/"stop" are used to describe if jobs
can be executed. Under normal operations, a queue is "enabled"/"started",
which allows users to submit jobs and jobs can run. If a queue is
"enabled"/"stopped", it means jobs can be submitted but not allowed to run.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"enabled"/"stopped", it means jobs can be submitted but not allowed to run.
"enabled"/"stopped," it means jobs can be submitted but not allowed to run.

glossary.rst Outdated
which allows users to submit jobs and jobs can run. If a queue is
"enabled"/"stopped", it means jobs can be submitted but not allowed to run.
This siutation is common if resources are temporarily down for maintenance.
If a queue is "disabled"/"started", previously submitted jobs can run, but no
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If a queue is "disabled"/"started", previously submitted jobs can run, but no
If a queue is "disabled"/"started," previously submitted jobs can run, but no

https://www.thesaurus.com/e/grammar/does-punctuation-go-inside-or-outside-quotation-marks/

glossary.rst Outdated
The
`Webster's dictionary <https://www.merriam-webster.com/dictionary/workflow>`_
definition is "the sequence of steps involved in moving from the beginning to
the end of a working process". In the context of Flux, this is usually a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the end of a working process". In the context of Flux, this is usually a
the end of a working process." In the context of Flux, this is usually a

@chu11
Copy link
Member Author

chu11 commented Feb 2, 2023

re-pushed with fixes / adjustments from comments above

@chu11 chu11 force-pushed the more_glossary branch 2 times, most recently from 8f0b042 to ae220e2 Compare February 2, 2023 16:20
Problem: The letter E comes before the letter F!

Move the "Eventlog" description higher up.
@chu11
Copy link
Member Author

chu11 commented Feb 10, 2023

rebased and re-pushed, "sub-instance" -> "subinstance"

Copy link
Member

@vsoch vsoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good.

@chu11 chu11 added the merge-when-passing mark PR for auto-merging by mergify.io bot label Feb 10, 2023
Problem: The glossary does not have enough stuff!

Add more.
@mergify mergify bot merged commit da6508c into flux-framework:master Feb 10, 2023
@chu11 chu11 deleted the more_glossary branch February 10, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-passing mark PR for auto-merging by mergify.io bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants