Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add --ignore-installed to pip install of requirements #293

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

wihobbs
Copy link
Member

@wihobbs wihobbs commented Jan 25, 2025

Problem: recently, our github workflow for spelling and
linkcheck got confused between pre-installed debian packages
and python's pip installed packages.

Just ignore the debian packages. Install our own. It doesn't
seem to take much longer.

-I, --ignore-installed

    Ignore the installed packages, overwriting them. This can break your system if the existing package is of a different version or was installed with a different package manager!

    (environment variable: PIP_IGNORE_INSTALLED)

From: https://pip.pypa.io/en/stable/cli/pip_install/

@wihobbs wihobbs force-pushed the requirements-update branch 2 times, most recently from 25343b4 to 151b639 Compare January 25, 2025 00:36
@wihobbs wihobbs changed the title requirements: drop deprecated version github: update workflow to aggressively pip install Jan 25, 2025
Copy link
Member

@jameshcorbett jameshcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK but can you explain what's going on?

@wihobbs
Copy link
Member Author

wihobbs commented Jan 25, 2025

The rabbit master hopped to this PR too quickly!

I'm fairly certain it's a problem with a mismatch between system installed packages in the container and what pip thinks is installed. As to why it's showing up now, I have no idea. 🤔

@wihobbs
Copy link
Member Author

wihobbs commented Jan 25, 2025

I guess I'll fess up to finding the "solution" on a very random blog

@grondo
Copy link
Contributor

grondo commented Jan 25, 2025

Maybe use commit title: "github: add --ignore-installed to pip install of requirements"?

Also the workflow specifies ubuntu-latest so maybe s/debian/ubuntu/ in the description?

@wihobbs
Copy link
Member Author

wihobbs commented Jan 25, 2025

I'm fine with that, but FWIW, the error message that prompted this specifies debian:

   Attempting uninstall: typing-extensions
    Found existing installation: typing_extensions 4.10.0
ERROR: Cannot uninstall typing_extensions 4.10.0, RECORD file not found. Hint: The package was installed by debian.
Error: Process completed with exit code 1.

Problem: recently, our github workflow for spelling and
linkcheck got confused between pre-installed ubuntu packages
and python's pip installed packages.

Just ignore the ubuntu packages. Install our own. It doesn't
seem to take much longer.
@wihobbs wihobbs force-pushed the requirements-update branch from 151b639 to 80a8adb Compare January 25, 2025 00:50
@wihobbs wihobbs changed the title github: update workflow to aggressively pip install github: add --ignore-installed to pip install of requirements Jan 25, 2025
Copy link
Member

@jameshcorbett jameshcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wihobbs wihobbs added the merge-when-passing mark PR for auto-merging by mergify.io bot label Jan 25, 2025
Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit 52b8dab into flux-framework:master Jan 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-passing mark PR for auto-merging by mergify.io bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants