Skip to content

Commit

Permalink
mpi: add openmpi to corona MPI tests
Browse files Browse the repository at this point in the history
Problem: We don't currently test OpenMPI and therefore
we don't really test flux-pmix.

Add OpenMPI to corona's MPI implementations list.
  • Loading branch information
wihobbs committed Jan 31, 2024
1 parent e3528e7 commit ab320ee
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion mpi/inner_script.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ cp -r $MPI_TESTS_DIRECTORY/* $FTC_DIRECTORY/$NAME
cd $FTC_DIRECTORY/$NAME || die "Could not find $FTC_DIRECTORY/$NAME"
echo "Running with $1 compiler and $2 MPI"
flux bulksubmit -n1 --watch mpicc -o {} {}.c ::: $TESTS || die "Compilation failure in tests"
flux bulksubmit --watch -N $BATCH_NNODES -n $BATCH_NCORES --output=kvs ./{} ::: $TESTS
flux bulksubmit --watch -N $BATCH_NNODES -n $BATCH_NCORES $EXTRA_FLUX_SUBMIT_OPTIONS --output=kvs ./{} ::: $TESTS
RC=$?
rm -rf $FTC_DIRECTORY/$NAME
exit $RC
7 changes: 6 additions & 1 deletion mpi/outer_script.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ intel-classic

corona_MPIS="
mvapich2
openmpi
"

export TESTS="hello
Expand All @@ -22,7 +23,11 @@ COMPILERS="${LCSCHEDCLUSTER}_COMPILERS"

for mpi in ${!MPIS}; do
for compiler in ${!COMPILERS}; do
flux batch -N2 -n4 --flags=waitable --output=kvs $MPI_TESTS_DIRECTORY/inner_script.sh $mpi $compiler
if [[ $mpi == "openmpi" ]]; then
EXTRA_FLUX_SUBMIT_OPTIONS="-o pmi=pmix" flux batch -N2 -n4 --flags=waitable --output=kvs $MPI_TESTS_DIRECTORY/inner_script.sh $mpi $compiler
else
flux batch -N2 -n4 --flags=waitable --output=kvs $MPI_TESTS_DIRECTORY/inner_script.sh $mpi $compiler
fi
done
done
flux job wait --all
Expand Down

0 comments on commit ab320ee

Please sign in to comment.